Merge pull request #3485 from dokku/fix-report

fix: ensure 'dokku report' always succeeds for any app

plugins/buildpacks/.gitignore

@@ -3,4 +3,5 @@
 /triggers/*
 /install
 /post-delete
+/post-extract
 /report

plugins/resource/resource.go

@@ -29,7 +29,7 @@ func ReportSingleApp(appName, infoFlag string) {
 
 	resources, err := common.PropertyGetAll("resource", appName)
 	if err != nil {
-		common.LogFail(err.Error())
+		return
 	}
 
 	flags := []string{}

tests/unit/40_report.bats

@@ -0,0 +1,48 @@
+#!/usr/bin/env bats
+
+load test_helper
+
+setup() {
+  global_setup
+  deploy_app
+}
+
+teardown() {
+  destroy_app
+  global_teardown
+}
+
+@test "(report) report" {
+  run /bin/bash -c "dokku report"
+  echo "output: $output"
+  echo "status: $status"
+  assert_output_contains "herokuish version:"
+  assert_success
+
+  run /bin/bash -c "dokku report $TEST_APP 2>&1"
+  echo "output: $output"
+  echo "status: $status"
+  assert_output_contains "herokuish version:"
+  assert_output_contains "not deployed" "0"
+  assert_success
+
+  run /bin/bash -c "dokku report fake-app-name"
+  echo "output: $output"
+  echo "status: $status"
+  assert_failure
+
+  run /bin/bash -c "dokku report fake-app-name 2>&1"
+  echo "output: $output"
+  echo "status: $status"
+  assert_output_contains "App fake-app-name does not exist"
+  assert_failure
+
+  dokku apps:create "${TEST_APP}-2"
+  run /bin/bash -c "dokku report ${TEST_APP}-2 2>&1"
+  echo "output: $output"
+  echo "status: $status"
+  assert_output_contains "not deployed"
+  assert_success
+
+  dokku --force apps:destroy "${TEST_APP}-2"
+}