github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: remove the per-app property folder on app delete and rename

Browse Source 
Switches the storage plugin's post-delete and post-app-rename-setup triggers from rewriting the attachment list as empty to removing the per-app property folder outright via PropertyDestroy. This matches the convention other plugins use on app deletion and avoids leaving an empty mounts file behind for an app that no longer exists.
This commit is contained in:
Jose Diaz-Gonzalez
2026-04-29 22:39:12 -04:00
parent 89afd09087
commit 6a5d568944
1 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
plugins/storage/triggers.go
View File

@@ -58,19 +58,15 @@ func TriggerInstall() error {
return nil
}
// TriggerPostDelete clears any attachment list for an app that's being
// destroyed. Entries are global and survive app deletion. Skipped when
// the app has no attachments to begin with so we don't trigger a
// pointless propertyTouch that could fail on installs with no
// property-list state for this plugin yet.
// TriggerPostDelete removes the attachment store for an app that's being
// destroyed. Entries are global and survive app deletion. The whole
// per-app property folder goes away rather than being rewritten as
// empty, matching what other plugins do on app deletion.
func TriggerPostDelete(appName string) error {
if appName == "" {
return nil
}
if !common.PropertyExists(PluginName, appName, AttachmentsProperty) {
return nil
}
return common.PropertyListWrite(PluginName, appName, AttachmentsProperty, []string{})
return common.PropertyDestroy(PluginName, appName)
}
// TriggerPostAppCloneSetup copies attachments from the source app to the
@@ -90,7 +86,7 @@ func TriggerPostAppCloneSetup(oldName string, newName string) error {
}
// TriggerPostAppRenameSetup moves attachments from the old name to the
// new name and clears the old.
// new name and removes the old per-app property folder.
func TriggerPostAppRenameSetup(oldName string, newName string) error {
if oldName == "" || newName == "" {
return nil
@@ -105,7 +101,7 @@ func TriggerPostAppRenameSetup(oldName string, newName string) error {
if err := SaveAttachments(newName, attachments); err != nil {
return err
}
return common.PropertyListWrite(PluginName, oldName, AttachmentsProperty, []string{})
return common.PropertyDestroy(PluginName, oldName)
}
// detectDistro returns the Linux distribution name