github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix: call the datastore create command the way it is documented

Browse Source 
The ports and app-json tests passed the app name to `postgres:create` and `redis:create` a second time, as a positional the command has never taken. The bash datastore plugins parsed their arguments with getopts and simply stopped at it; those plugins now dispatch to a binary that reports the count instead, so every dokku pull request fails on `This command requires 2 arguments, 3 arguments given`.

The documented form takes the service alone, as `docs/deployment/application-deployment.md` shows. The `:link` and `:unlink` calls beside these are unchanged, since those do take two.
This commit is contained in:
Jose Diaz-Gonzalez
2026-09-20 02:53:32 -04:00
parent f36512a19d
commit 57bbe917b0
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/unit/app-json.bats
View File

@@ -144,7 +144,7 @@ teardown() {
echo "status: $status"
assert_success
run /bin/bash -c "dokku postgres:create $TEST_APP $TEST_APP"
run /bin/bash -c "dokku postgres:create $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_success
@@ -154,7 +154,7 @@ teardown() {
echo "status: $status"
assert_success
run /bin/bash -c "dokku redis:create $TEST_APP $TEST_APP"
run /bin/bash -c "dokku redis:create $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_success

4
tests/unit/ports.bats
View File

@@ -274,7 +274,7 @@ teardown() {
echo "status: $status"
assert_success
run /bin/bash -c "dokku postgres:create $TEST_APP $TEST_APP"
run /bin/bash -c "dokku postgres:create $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_success
@@ -284,7 +284,7 @@ teardown() {
echo "status: $status"
assert_success
run /bin/bash -c "dokku redis:create $TEST_APP $TEST_APP"
run /bin/bash -c "dokku redis:create $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_success