github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: rename app-json:report flags to match property

Browse Source 
The property name set via `app-json:set` is `appjson-path`, but the matching read-back flags on `app-json:report` were named `--app-json-selected`, `--app-json-global-selected`, and `--app-json-computed-selected`. The mismatch meant `dokku app-json:report <app> --app-json-appjson-path` (the form already documented in deployment-tasks.md) was rejected as an invalid flag, and the `--format json` output advertised keys that did not correspond to any settable property. The flags and JSON keys are renamed to `--app-json-appjson-path`, `--app-json-global-appjson-path`, and `--app-json-computed-appjson-path` so that the property name round-trips through set and report.
This commit is contained in:
Jose Diaz-Gonzalez
2026-05-10 22:32:16 -04:00
parent a553f04966
commit 4eee229bbc
2 changed files with 61 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/app-json/report.go
View File

@@ -15,13 +15,13 @@ func ReportSingleApp(appName string, format string, infoFlag string) error {
var flags map[string]common.ReportFunc
if appName == "--global" {
flags = map[string]common.ReportFunc{
"--app-json-global-selected": reportGlobalAppjsonpath,
"--app-json-global-appjson-path": reportGlobalAppjsonpath,
}
} else {
flags = map[string]common.ReportFunc{
"--app-json-computed-selected": reportComputedAppjsonpath,
"--app-json-global-selected": reportGlobalAppjsonpath,
"--app-json-selected": reportAppjsonpath,
"--app-json-computed-appjson-path": reportComputedAppjsonpath,
"--app-json-global-appjson-path": reportGlobalAppjsonpath,
"--app-json-appjson-path": reportAppjsonpath,
}
}

57
tests/unit/app-json.bats
View File

@@ -256,6 +256,63 @@ teardown() {
assert_output_contains "touch /app/predeploy3.test"
}
@test "(app-json:report) appjson-path round-trip" {
run /bin/bash -c "dokku app-json:set $TEST_APP appjson-path app2.json"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "dokku app-json:report $TEST_APP --app-json-appjson-path"
echo "output: $output"
echo "status: $status"
assert_success
assert_output "app2.json"
run /bin/bash -c "dokku app-json:report $TEST_APP --app-json-computed-appjson-path"
echo "output: $output"
echo "status: $status"
assert_success
assert_output "app2.json"
run /bin/bash -c "dokku app-json:report $TEST_APP --app-json-global-appjson-path"
echo "output: $output"
echo "status: $status"
assert_success
assert_output "app.json"
run /bin/bash -c "dokku app-json:report $TEST_APP --format json"
echo "output: $output"
echo "status: $status"
assert_success
assert_output_contains '"app-json-appjson-path":"app2.json"'
assert_output_contains '"app-json-computed-appjson-path":"app2.json"'
assert_output_contains '"app-json-global-appjson-path":"app.json"'
assert_output_contains "app-json-selected" 0
run /bin/bash -c "dokku app-json:report $TEST_APP --app-json-selected"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "Invalid flag passed"
run /bin/bash -c "dokku app-json:set $TEST_APP appjson-path"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "dokku app-json:report $TEST_APP --app-json-appjson-path"
echo "output: $output"
echo "status: $status"
assert_success
assert_output ""
run /bin/bash -c "dokku app-json:report $TEST_APP --app-json-computed-appjson-path"
echo "output: $output"
echo "status: $status"
assert_success
assert_output "app.json"
}
copy_app_json_to_sub_app() {
local APP="$1"
local APP_REPO_DIR="$2"