feat: ensure we inject environment variables into the docker container create call in app-json
This fixes an issue where the values are empty for CNB applications.
This commit is contained in:
1 parent
0405b36ab4
commit
34807028db
1 file changed
+11
-1
@@ -366,15 +366,25 @@ func createdContainerID(appName string, dockerArgs []string, image string, comma
|
|||||||
arguments = append(arguments, image)
|
arguments = append(arguments, image)
|
||||||
arguments = append(arguments, command...)
|
arguments = append(arguments, command...)
|
||||||
|
|
||||||
|
b, err := common.PlugnTriggerOutput("config-export", []string{appName, "false", "true", "json"}...)
|
||||||
|
if err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
var env map[string]string
|
||||||
|
if err := json.Unmarshal(b, &env); err != nil {
|
||||||
|
return "", err
|
||||||
|
}
|
||||||
|
|
||||||
containerCreateCmd := common.NewShellCmdWithArgs(
|
containerCreateCmd := common.NewShellCmdWithArgs(
|
||||||
common.DockerBin(),
|
common.DockerBin(),
|
||||||
arguments...,
|
arguments...,
|
||||||
)
|
)
|
||||||
var stderr bytes.Buffer
|
var stderr bytes.Buffer
|
||||||
|
containerCreateCmd.Env = env
|
||||||
containerCreateCmd.ShowOutput = false
|
containerCreateCmd.ShowOutput = false
|
||||||
containerCreateCmd.Command.Stderr = &stderr
|
containerCreateCmd.Command.Stderr = &stderr
|
||||||
|
|
||||||
b, err := containerCreateCmd.Output()
|
b, err = containerCreateCmd.Output()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return "", errors.New(stderr.String())
|
return "", errors.New(stderr.String())
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in new issue
Block a user