From 34807028dbebd0ba89163874fe619ece7822f87a Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Thu, 11 Feb 2021 06:43:15 -0500 Subject: [PATCH] feat: ensure we inject environment variables into the docker container create call in app-json This fixes an issue where the values are empty for CNB applications. --- plugins/app-json/functions.go | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/plugins/app-json/functions.go b/plugins/app-json/functions.go index 750944a29..042600dc9 100644 --- a/plugins/app-json/functions.go +++ b/plugins/app-json/functions.go @@ -366,15 +366,25 @@ func createdContainerID(appName string, dockerArgs []string, image string, comma arguments = append(arguments, image) arguments = append(arguments, command...) + b, err := common.PlugnTriggerOutput("config-export", []string{appName, "false", "true", "json"}...) + if err != nil { + return "", err + } + var env map[string]string + if err := json.Unmarshal(b, &env); err != nil { + return "", err + } + containerCreateCmd := common.NewShellCmdWithArgs( common.DockerBin(), arguments..., ) var stderr bytes.Buffer + containerCreateCmd.Env = env containerCreateCmd.ShowOutput = false containerCreateCmd.Command.Stderr = &stderr - b, err := containerCreateCmd.Output() + b, err = containerCreateCmd.Output() if err != nil { return "", errors.New(stderr.String()) }