10255 Commits
Author SHA1 Message Date
Jose Diaz-Gonzalez 0bd785e04e feat: add logging to command plugn trigger output when executed with trace mode on 2024-02-21 18:15:37 -05:00
Jose Diaz-Gonzalez 3843ac2de2 fix: do not print command directly and instead use LogWarn to send to stdout
If we use the standard logging method from go-execute, any subprocess calls through plugn may capture the wrong output due to handling stdout.
2024-02-21 18:15:11 -05:00
Jose Diaz-Gonzalez 05c48430c5 fix: correct issue where resource values were ignored 2024-02-21 18:13:47 -05:00
Jose Diaz-Gonzalez 20a9e3a61f Merge pull request #6607 from dokku/6602-unbuffered-logs
Call sed in unbuffered form to ensure log output is streamed to stdout
2024-02-21 16:49:04 -05:00
Jose Diaz-Gonzalez a894c03043 fix: call sed in unbuffered form to ensure log output is streamed to stdout
The new exec callers somehow setup the environment differently, causing sed to not properly detect that it should run in unbuffered form. This change forces sed to run in unbuffered mode.

Closes #6602
2024-02-21 15:19:45 -05:00
Jose Diaz-Gonzalez c4b3cc9639 Merge pull request #6604 from dokku/dependabot/pip/docs/_build/mkdocs-material-9.5.10
chore(deps): bump mkdocs-material from 9.5.9 to 9.5.10 in /docs/_build
2024-02-20 14:52:16 -05:00
Jose Diaz-Gonzalez 5d805481a2 Merge pull request #6603 from dokku/dependabot/github_actions/tj-actions/changed-files-42.0.4
chore(deps): bump tj-actions/changed-files from 42.0.2 to 42.0.4
2024-02-20 14:52:10 -05:00
dependabot[bot] d786c5dcd8 chore(deps): bump mkdocs-material from 9.5.9 to 9.5.10 in /docs/_build
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.9 to 9.5.10.
- [Release notes](https://github.com/squidfunk/mkdocs-material/releases)
- [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG)
- [Commits](https://github.com/squidfunk/mkdocs-material/compare/9.5.9...9.5.10)

---
updated-dependencies:
- dependency-name: mkdocs-material
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-19 13:42:20 +00:00
dependabot[bot] eba8c0b262 chore(deps): bump tj-actions/changed-files from 42.0.2 to 42.0.4
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 42.0.2 to 42.0.4.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](https://github.com/tj-actions/changed-files/compare/v42.0.2...v42.0.4)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-19 13:31:28 +00:00
Jose Diaz-Gonzalez 96afb713b7 Merge pull request #6601 from dokku/dependabot/go_modules/plugins/scheduler-k3s/helm.sh/helm/v3-3.14.1
chore(deps): bump helm.sh/helm/v3 from 3.13.3 to 3.14.1 in /plugins/scheduler-k3s
2024-02-17 06:18:32 -05:00
dependabot[bot] 5e03ad1dd0 chore(deps): bump helm.sh/helm/v3 in /plugins/scheduler-k3s
Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.13.3 to 3.14.1.
- [Release notes](https://github.com/helm/helm/releases)
- [Commits](https://github.com/helm/helm/compare/v3.13.3...v3.14.1)

---
updated-dependencies:
- dependency-name: helm.sh/helm/v3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-15 15:39:56 +00:00
Jose Diaz-Gonzalez 3b29081885 Merge pull request #6600 from dokku/k3s-fix-labels
Use correct label key for worker nodes
2024-02-14 21:53:18 -05:00
Jose Diaz-Gonzalez 0b145e01f0 fix: use correct label key for worker nodes 2024-02-14 21:52:11 -05:00
Jose Diaz-Gonzalez f0707bd368 Merge pull request #6596 from dokku/dependabot/go_modules/tests/apps/gogrpc/google.golang.org/grpc-1.61.1
chore(deps): bump google.golang.org/grpc from 1.61.0 to 1.61.1 in /tests/apps/gogrpc
2024-02-14 11:55:03 -05:00
dependabot[bot] eded4f6df6 chore(deps): bump google.golang.org/grpc in /tests/apps/gogrpc
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.61.0 to 1.61.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.61.0...v1.61.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-14 13:48:34 +00:00
Jose Diaz-Gonzalez f49e7ff722 Merge pull request #6594 from dokku/6422-remove-new-shell
Remove all calls to common.NewShellCmd
2024-02-14 03:51:30 -05:00
Jose Diaz-Gonzalez 2d4c71add6 fix: stream both stdout and stderr 2024-02-14 00:33:20 -05:00
Jose Diaz-Gonzalez 8158f6aea0 fix: ignore case where crontab does not exist for user 2024-02-13 01:23:36 -05:00
Jose Diaz-Gonzalez 44dd933638 refactor: remove all calls to common.NewShellCmd
At this point, the only usage of go-sh should be by plugin trigger calls.
2024-02-13 01:09:24 -05:00
Jose Diaz-Gonzalez 24b32432e6 Merge pull request #6593 from dokku/golangci-lint
Remove extra trailing newline to fix govet issue
2024-02-12 23:30:10 -05:00
Jose Diaz-Gonzalez a8c488f249 Merge pull request #6592 from dokku/6422-remove-new-shell
refactor: remove all calls to common.NewShellCmdWithArgs
2024-02-12 22:13:58 -05:00
Jose Diaz-Gonzalez d99f0f0a93 Merge pull request #6591 from dokku/6422-more-sh-cleanup
Always capture stdout/stderr when executing subprocesses
2024-02-12 22:13:47 -05:00
Jose Diaz-Gonzalez fe262a3a3c chore: remove extra trailing newline 2024-02-12 21:43:45 -05:00
Jose Diaz-Gonzalez d8401a4d86 refactor: remove all calls to common.NewShellCmdWithArgs 2024-02-12 20:58:51 -05:00
Jose Diaz-Gonzalez 3c6cc68086 refactor: capture output by default
This is almost certainly the correct default for Dokku. While it's a BC break and might cause an increase in memory usage, the api is mostly internal and therefore this is safe to use.
2024-02-12 20:28:31 -05:00
Jose Diaz-Gonzalez 047a3c00f5 chore: remove default false values when calling CallExecCommand 2024-02-12 20:07:43 -05:00
Jose Diaz-Gonzalez 8b9dcd2242 Merge pull request #6590 from dokku/6422-remove-direct-sh-calls
Remove all direct usage of go-sh outside of plugin trigger setup
2024-02-12 20:03:05 -05:00
Jose Diaz-Gonzalez 8a940c6e47 chore: remove all direct usage of go-sh outside of plugin trigger setup
The new way is to use CallExecCommand instead.
2024-02-12 19:29:16 -05:00
Dokku Bot 688ee518af Release 0.33.6
# History

## 0.33.6

Install/update via the bootstrap script:

```shell
wget -NP . https://dokku.com/install/v0.33.6/bootstrap.sh
sudo DOKKU_TAG=v0.33.6 bash bootstrap.sh
```

### Bug Fixes

- #6589: @josegonzalez Use image pull secrets instead of registries.yaml to reference private repositories when deploying via k3s
- #6581: @josegonzalez Fix issues in tls handling when deploying via k3s
- #6582: @josegonzalez Correctly handle extra whitespace in scale file contents
- #6390: @renweibo Prefer systemctl over sv when both exist while restarting nginx
- #6579: @josegonzalez Ensure k3s can be installed with taints

### New Features

- #6585: @josegonzalez Add more context to errors in fetching cron entries
- #6583: @josegonzalez Add WithContext functions for all subprocess-related code

### Refactors

- #6584: @josegonzalez Use new CallExecCommand when checking to see how help is being called

### Dependencies

- #6586: @dependabot[bot] chore(deps): bump mvdan.cc/sh/v3 from 3.7.0 to 3.8.0 in /plugins/cron
- #6587: @dependabot[bot] chore(deps): bump mkdocs-material from 9.5.8 to 9.5.9 in /docs/_build
- #6381: @dependabot[bot] chore(deps): bump actions/upload-artifact from 3 to 4
- #6578: @josegonzalez Bump go modules

### Other

- #6576: @Tashows Allow creating a detached container with TTY enabled for attaching remote terminal
v0.33.6
2024-02-12 22:56:50 +00:00
Jose Diaz-Gonzalez 2e326b718e Merge pull request #6589 from dokku/k3s-image-pull-secrets
Use image pull secrets instead of registries.yaml to reference private repositories when deploying via k3s
2024-02-12 17:54:49 -05:00
Jose Diaz-Gonzalez 1ae2df52f5 fix: use image pull secrets instead of registries.yaml to reference private repositories
While this will now more or less require a local docker login - which can be overridden by setting the image-pull-secrets property - this ensures every deploy has a valid context.

One annoying thing is that the secret is per-app vs global, meaning that if the secret must be rotated, all apps need to be redeployed. A future change can fix that by deploying a global secret, or if folks really desire, this can be done by setting the image-pull-secrets property on the app/globally.
2024-02-12 17:15:37 -05:00
Jose Diaz-Gonzalez 91151cf375 Merge pull request #6581 from dokku/tls-handling
Fix issues in tls handling when deploying via k3s
2024-02-12 16:38:39 -05:00
Jose Diaz-Gonzalez 3c5f95ff18 chore: update dependencies 2024-02-12 16:28:57 -05:00
Jose Diaz-Gonzalez 53dc81d873 Merge pull request #6586 from dokku/dependabot/go_modules/plugins/cron/mvdan.cc/sh/v3-3.8.0
chore(deps): bump mvdan.cc/sh/v3 from 3.7.0 to 3.8.0 in /plugins/cron
2024-02-12 16:20:20 -05:00
Jose Diaz-Gonzalez f80151bb3a Merge pull request #6587 from dokku/dependabot/pip/docs/_build/mkdocs-material-9.5.9
chore(deps): bump mkdocs-material from 9.5.8 to 9.5.9 in /docs/_build
2024-02-12 16:18:21 -05:00
dependabot[bot] 62e85cc752 chore(deps): bump mkdocs-material from 9.5.8 to 9.5.9 in /docs/_build
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.8 to 9.5.9.
- [Release notes](https://github.com/squidfunk/mkdocs-material/releases)
- [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG)
- [Commits](https://github.com/squidfunk/mkdocs-material/compare/9.5.8...9.5.9)

---
updated-dependencies:
- dependency-name: mkdocs-material
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-12 14:03:15 +00:00
dependabot[bot] e6c17059f9 chore(deps): bump mvdan.cc/sh/v3 from 3.7.0 to 3.8.0 in /plugins/cron
Bumps [mvdan.cc/sh/v3](https://github.com/mvdan/sh) from 3.7.0 to 3.8.0.
- [Release notes](https://github.com/mvdan/sh/releases)
- [Changelog](https://github.com/mvdan/sh/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mvdan/sh/compare/v3.7.0...v3.8.0)

---
updated-dependencies:
- dependency-name: mvdan.cc/sh/v3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-12 13:20:58 +00:00
Jose Diaz-Gonzalez d12eff3fe4 Merge pull request #6585 from dokku/cron-errors
Add more context to errors in fetching cron entries
2024-02-12 03:11:23 -05:00
Jose Diaz-Gonzalez f74b306c8c Merge pull request #6584 from dokku/6422-update-help
fix: use new CallExecCommand when checking to see how help is being called
2024-02-12 02:38:49 -05:00
Jose Diaz-Gonzalez 22e1bb6466 feat: add more context to errors in fetching cron entries 2024-02-12 02:37:43 -05:00
Jose Diaz-Gonzalez abbc13cb85 fix: ensure the ingress class is properly set for certificate usage
Without this, switching to nginx ingress fails as the cluster issuer isn't properly configured
2024-02-12 01:31:39 -05:00
Jose Diaz-Gonzalez 433eb26f3c feat: always skip the https ingress/ingress-route/deployment port entry if there is a corresponding http entry
Also inject the corresponding entries as necessary
2024-02-12 01:31:39 -05:00
Jose Diaz-Gonzalez bfccf60a37 refactor: simplify tls handling by always redirecting 2024-02-12 01:31:39 -05:00
Jose Diaz-Gonzalez 50239b056c fix: use new CallExecCommand when checking to see how help is being called
This is part of ongoing work to remove usage of the depreated NewShellCmd.
2024-02-12 00:55:16 -05:00
Jose Diaz-Gonzalez 541eb1a1bc Merge pull request #6583 from dokku/6422-context-wrappers
Add WithContext functions for all subprocess-related code
2024-02-12 00:37:57 -05:00
Jose Diaz-Gonzalez bcf25ba5cd feat: add WithContext functions for all subprocess-related code
Also deprecate the existing subprocess calls.
2024-02-11 23:04:20 -05:00
Jose Diaz-Gonzalez 03df28af87 Merge pull request #6582 from dokku/ps-cleanup
Correctly handle extra whitespace in scale file contents
2024-02-11 22:48:15 -05:00
Jose Diaz-Gonzalez f5018ce70f chore: fix shfmt issue 2024-02-11 22:02:36 -05:00
Jose Diaz-Gonzalez a5a05c2c44 chore: update procfile-util dependency
Also run formatting against the file.
2024-02-11 22:01:20 -05:00
Jose Diaz-Gonzalez 3adb7b615a feat: add test for scale formatting issues 2024-02-11 21:56:18 -05:00