Commit Graph
25 Commits
Author SHA1 Message Date
Jose Diaz-Gonzalez fba0681e5b fix: avoid glob expansion of app domains
A catch-all `*` domain or a wildcard ssl hostname could be expanded into file names from the current directory when generating app urls, healthcheck `Host` headers, or the nginx ssl server names.
2026-11-02 00:33:35 -05:00
Jose Diaz-Gonzalez a4484d354b fix: validate app name in app-scoped commands 2026-09-24 18:14:53 -04:00
Jose Diaz-Gonzalez 8d0c36bad6 feat: port checks and domains :report subcommands to golang
The bash :report implementations for the checks and domains plugins are replaced with a compiled golang binary that collects report keys in parallel and marshals json directly. The domains global report header now matches the shared renderer used by every other golang report, and its bats assertion is updated accordingly.
2026-07-07 06:43:31 -04:00
Jose Diaz-Gonzalez e8d8b0683a fix: preserve info flag in plugin reports with --global
The argument-handling block in each plugin's report command overwrote APP with --global before checking whether $1 actually held an info flag, so `dokku <plugin>:report --global --<plugin>-foo` always emitted the full report instead of the requested value. Reorder the conditionals across the sixteen plugins that share the pattern so the info-flag check runs first, and add a regression bats case for each one.
2026-04-30 21:05:46 -04:00
Jose Diaz-Gonzalez 8282981361 feat: accept --global on :report subcommands
Every `:report` subcommand now recognizes `--global` as a scope selector that limits the report to globally-configured properties, including in JSON form via `--global --format json`. Previously this combination was rejected because `--global` was treated as an info flag, conflicting with `--format`. The shared `common.ParseReportArgs` helper now returns a `ReportArgs` struct exposing the parsed scope; each Go and bash report selects a global-only flag map when scope is global, and skips per-app verification.
2026-04-29 10:30:59 -04:00
Jose Diaz-Gonzalez c2a07c3f1c fix: preserve all domains when renaming an app
The `post-app-rename-setup` trigger redirected `sed` output to the new
app's VHOST file inside a loop over global vhosts, so each iteration
clobbered the previous one and only the last global subdomain was
rewritten. When no global vhost was set, the loop never ran and the
new app's VHOST file was never written, leaving the renamed app with
no domains.

Copy the old app's VHOST file once as a baseline, then apply `sed -i`
in place for each global vhost so substitutions accumulate. Guard
against a missing global VHOST file and skip blank lines.
2026-04-27 01:47:50 -04:00
Jose Diaz-Gonzalez bf7e5a7312 tests: add a test for apps that detect https:443:443 port mappings without an ssl cert 2025-09-07 22:06:24 -04:00
Jose Diaz-Gonzalez b11c72d0ae tests: update test logic 2025-07-02 01:17:57 -04:00
Álvaro Justen (@turicas) 67311264d7 Implement domains:reset 2025-07-01 20:11:48 -04:00
Jose Diaz-Gonzalez 5846301a48 tests: make it possible to specify an alternative base domain for tests
When developing Dokku, it is useful to use a real domain to test actual functionality. This is impossible if the domain is hardcoded to dokku.me in testing.
2023-08-05 20:58:26 -04:00
Jose Diaz-Gonzalez 622548057c tests: add assertions to various bats tests
Missing these assertions didn't necessarily break tests but they are more correct and having them should help suss out bugs.
2023-08-05 10:58:57 -04:00
josegonzalez 2cd028e577 tests: add test for default _ domain usage 2023-05-13 13:57:27 -04:00
Jose Diaz-Gonzalez 1dda402769 fix: do not depend upon domains:setup in tests
Since it is now called on app creation, it doesn't work as expected for 'resetting' already set state.
2022-12-02 02:33:54 -05:00
Jose Diaz-Gonzalez f4f0a29446 fix: correct domain wildcard tests for new domain initialization method 2022-12-01 22:57:31 -05:00
Jose Diaz-Gonzalez 4da1f7091a fix: run shfmt 2022-11-23 17:49:41 -05:00
Jose Diaz-Gonzalez 47f5af44c5 tests: add a test for the error message 2022-11-23 17:46:33 -05:00
Jose Diaz-Gonzalez 26e7a16fd7 fix: only rename app domains associated with a global domain
Closes #4965
2022-01-28 22:38:24 -05:00
Jose Diaz-Gonzalez a1c768b9b3 refactor: drop web installer in favor of setup via cli
This makes the installation a bit more secure by ensuring a user does not accidentally expose a way for unauthorized users to add new ssh keys to the system.

Additionally, this removes the extra HOSTNAME file to make the initial install process easier (that file was not modifiable by any dokku commands.

Closes #2247
2021-08-07 16:36:41 -04:00
Jose Diaz-Gonzalez 5fd04001d8 feat: split out test files and execute them manually
This breaks the old grouping mechanism, but honestly that was a weird way of doing it.
2020-06-20 13:22:47 -04:00
Michael Hobbs 76ad65b715 don't run app deploy tests and spread out unit tests to 4 containers. closes #1787 2015-12-21 10:18:16 -08:00
Michael Hobbs 4b2a777425 add test for wildcard domain. don't match domain substring. closes #1614 2015-11-19 12:03:31 -05:00
Michael Hobbs dce031d38d don't re-deploy on domains:add. allow multple domains on command line. closes #1142 2015-04-24 15:41:32 -07:00
Michael Hobbs 4e472c39e3 uniform unit test labels 2015-04-01 17:44:34 -07:00
Michael Hobbs 896ce50c93 support pre deployment usage of domains plugin. fixes interface binding issue 2015-01-06 12:42:21 -08:00
Michael Hobbs 283432f214 domains plugin unit tests and fix for errant substring match 2014-12-21 14:51:42 -08:00