Commit Graph
10 Commits
Author SHA1 Message Date
Jose Diaz-Gonzalez b04d12d67e fix: read alternate image tags from the retired container
On hosts using the containerd image store, an app's previous image can be removed once its tag moves to a new build, even while the old container is still running. The alternate tag lookup then failed, so an image deployed via `git:from-image` was never queued for retirement.
2026-10-23 20:37:48 -04:00
Jose Diaz-Gonzalez d88e8f137f fix: skip retiring images still in use by app containers
When ps:rebuild runs against an image-based deploy via git:from-image, the resulting image often shares the same SHA as the previous deployment, so retiring the old container's image would target the live image of the new container. The retirement is now skipped when another running container of the same app still references the image, and the cron retire loop self-heals previously stuck entries the next time it encounters them.
2026-04-29 05:36:04 -04:00
Jose Diaz-Gonzalez 510cbd2d34 fix: keep image specified by git:from-image on app rebuild
Rather than always delete the image, we will now check if the alt image tag is equivalent to the source-image specified by the git:from-image command. If it is, we will ignore deletion.

Closes #5702
2023-03-18 04:55:54 -04:00
Jose Diaz-Gonzalez 9616473c3a fix: ensure we retire any alternate tags
Dokku currently injects an alternate tag into the image. Without this change, deploying new image tags (via push with a Dockerfile or git:from-image) would result in the old images lying around forever. This change ensures they are registered for removal.

Closes #4825
2021-10-09 18:46:48 -04:00
Jose Diaz-Gonzalez 7a564f3185 fix: do not retire the original image
By removing the image cleanup registration, we avoid cases where we delete gliderlabs/herokuish, which may cause issues for users in airgapped installations (where the image may not be pullable from a registry).
2021-08-08 02:24:27 -04:00
Jose Diaz-Gonzalez 8766820974 fix: always retire deployment task containers
Without this, the normal cleanup routine would not remove the containers, and removal would require a manual call to 'dokku cleanup'.
2021-05-22 15:37:21 -04:00
Jose Diaz-Gonzalez 6cd50cb372 fix: ensure the image is not an empty string 2020-11-28 18:46:37 -05:00
Jose Diaz-Gonzalez e8a532645f fix: handle case where container does not exist during retire step
This ma happen during app renames, as the old versions of the containers will no longer be running.
2020-11-28 00:38:28 -05:00
Jose Diaz-Gonzalez 0786954d34 feat: schedule related images for cleanup when retiring containers
If the containers no longer exist and the images are unused, we should remove the images as well.

Note that images may sometimes stick around for a little while, depending on the retire schedule and the wait time specified for the container.

Closes #4104
2020-11-26 03:21:45 -05:00
Jose Diaz-Gonzalez ef490f0a05 feat: retire intermediate containers after use
Rather than waiting for the next deploy, take advantage of the retire system to retire these containers immediately.

Note that since the retire process happens out of band, the containers may stick around for up to 5 minutes, after which point they will be removed.

Customization of the wait time to retire - currently 60 seconds - is up for future debate. The containers ultimately haven't been useful for debugging, so keeping them around for longer won't help in most cases, and folks can disable the dokku-retire service (or cron) if that is desired.
2020-11-22 16:57:39 -05:00