Commit Graph
14679 Commits
Author SHA1 Message Date
Jose Diaz-Gonzalez 9ce309bed9 fix: correct SC2206 issue 2021-02-13 02:36:36 -05:00
Jose Diaz-Gonzalez b62264c275 tests: fix SC2124 issue 2021-02-13 02:32:17 -05:00
Jose Diaz-Gonzalez d4e832c27b tests: fix SC2145 issue 2021-02-13 02:31:24 -05:00
Jose Diaz-Gonzalez 59c45ea1d6 tests: fix SC1012 issue 2021-02-13 02:28:38 -05:00
Jose Diaz-Gonzalez f64a754211 tests: fix some shellcheck violations 2021-02-13 02:22:21 -05:00
Jose Diaz-Gonzalez d8895bb64b tests: fix SC1087 violations 2021-02-13 02:17:25 -05:00
Jose Diaz-Gonzalez 882889a962 tests: fix shfmt 2021-02-13 02:14:50 -05:00
Jose Diaz-Gonzalez 7338a77285 tests: fix more yaml issues 2021-02-13 02:14:10 -05:00
Jose Diaz-Gonzalez af014750aa tests: fix and ignore shellcheck errors 2021-02-13 02:09:24 -05:00
Jose Diaz-Gonzalez 02a8409114 tests: fix shfmt issues 2021-02-13 02:05:44 -05:00
Jose Diaz-Gonzalez 3681c17aa2 tests: fix lint issues in yaml files 2021-02-13 02:02:33 -05:00
Jose Diaz-Gonzalez f56023bb74 tests: upgrade linters 2021-02-13 02:00:10 -05:00
Jose Diaz-Gonzalez 5ef41861d3 tests: cleanup and ignore markdown lint issues 2021-02-13 01:57:00 -05:00
Jose Diaz-Gonzalez a679e80187 tests: update hadolint and ignore some errors 2021-02-13 01:54:55 -05:00
Jose Diaz-Gonzalez 85c841da88 tests: lint files during CI 2021-02-13 01:37:31 -05:00
Jose Diaz-Gonzalez 7cabb4dd9a Release 0.23.4
bump-formula / bump-formula (push) Has been cancelled
# History

## 0.23.4

Install/update via the bootstrap script:

```shell
wget https://raw.githubusercontent.com/dokku/dokku/v0.23.4/bootstrap.sh
sudo DOKKU_TAG=v0.23.4 bash bootstrap.sh
```

### Bug Fixes

- #4402: @josegonzalez fix: correctly handle is-deployed check
- #4399: @josegonzalez Drop extra log output in cron plugin

### Documentation

- #4400: @solvethex Add tail option
v0.23.4
2021-02-13 01:10:45 -05:00
Jose Diaz-Gonzalez 286be7f3df Merge pull request #4402 from dokku/4398-fix-deployed-check
fix: correctly handle is-deployed check
2021-02-13 01:10:22 -05:00
Jose Diaz-Gonzalez 1e915968b5 fix: correctly handle is-deployed check
Previously, checking if an app was deployed actually checked if there were any running processes. This is not only incorrect, but also fails to take into account applications that do not have running processes and are only used for one-off commands.

This fix migrates apps to the new "deployed" property which is set in core-post-deploy. The result is a slightly faster "deployed" check that is correct and allows non-scaled apps to actually work.

Closes #4398
2021-02-13 00:46:35 -05:00
Jose Diaz-Gonzalez 3dfb84048c Merge pull request #4400 from solvethex/patch-1
Add tail option
2021-02-12 23:29:25 -05:00
Jose Diaz-Gonzalez 78a3570bb2 docs: sync with help output
[ci skip]
2021-02-12 23:29:12 -05:00
Jose Diaz-Gonzalez 9733bf9fa1 Merge pull request #4399 from dokku/drop-extra-log
Drop extra log output in cron plugin
2021-02-12 23:28:03 -05:00
solvethex effaa8e81c Add tail option
Add tail option for realtime debugging
2021-02-12 14:22:57 +01:00
Jose Diaz-Gonzalez 7558a9898e fix: drop extra log output in cron plugin 2021-02-12 00:49:07 -05:00
Jose Diaz-Gonzalez eca6cde934 docs: fix redirect of one-off-processes documentation
[ci skip]
2021-02-11 12:21:33 -05:00
Jose Diaz-Gonzalez 197f0c7c95 Release 0.23.3
bump-formula / bump-formula (push) Has been cancelled
# History

## 0.23.3

Install/update via the bootstrap script:

```shell
wget https://raw.githubusercontent.com/dokku/dokku/v0.23.3/bootstrap.sh
sudo DOKKU_TAG=v0.23.3 bash bootstrap.sh
```

### Bug Fixes

- #4397: @josegonzalez Correctly handle environment variables in deployment tasks for Cloud Native Buildpacks
- #4394: @josegonzalez Swap order of arguments on config-get call

### New Features

- #4395: @josegonzalez Add environment variable support to CNB-based containers

### Refactors

- #4393: @josegonzalez Use docker-image-labeler in cnb builder-build trigger

### Documentation

- #4396: @nerg4l Invalid link to Herokuish Buildpack Deployment in Cloud Native Buildpacks

### Tests

- #4390: @josegonzalez Run tests faster by not cloning the buildpack each time

### Other

- #4389: @dependabot-preview[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 188 to 189 in /tests/apps/php
v0.23.3
2021-02-11 07:58:47 -05:00
Jose Diaz-Gonzalez ef2682945c Merge pull request #4397 from dokku/cnb-deployment-tasks
Correctly handle environment variables in deployment tasks for Cloud Native Buildpacks
2021-02-11 07:57:55 -05:00
Jose Diaz-Gonzalez 5e7ea4217f tests: install pack for app-json tests 2021-02-11 07:34:27 -05:00
Jose Diaz-Gonzalez 123fbea7c0 feat: add a deployment task test for cnb 2021-02-11 07:16:54 -05:00
Jose Diaz-Gonzalez 0673fdff2d fix: handle new herokuish image detection in deployment tasks 2021-02-11 07:16:43 -05:00
Jose Diaz-Gonzalez e07befb93c Merge pull request #4396 from nerg4l/documentation-patch-cloud-native-buildpacks-link
Invalid link to Herokuish Buildpack Deployment in Cloud Native Buildpacks
2021-02-11 07:15:49 -05:00
László Görög 8e1f890322 docs: fix link
[ci skip]
2021-02-11 13:12:07 +01:00
Jose Diaz-Gonzalez 8ca713f6bb fix: handle empty start command for cnb apps
We should instead fetch the command from the Procfile.
2021-02-11 06:53:48 -05:00
Jose Diaz-Gonzalez da1ddee0ba fix: override the launcher for cnb apps since the default launcher is the process launcher... 2021-02-11 06:51:01 -05:00
Jose Diaz-Gonzalez d48cf24c4d fix: unify IsImageHerokuishBased with shell version
Really we should just spit this out into a bin and then have the shell version wrap the golang ones...
2021-02-11 06:49:19 -05:00
Jose Diaz-Gonzalez 5614475521 refactor: reverse if statements
The shell version of IsImageHerokuishBased returns true if it is CNB for legacy reasons...
2021-02-11 06:48:38 -05:00
Jose Diaz-Gonzalez b826770687 fix: add cnb fix to copy_from_image 2021-02-11 06:43:37 -05:00
Jose Diaz-Gonzalez 34807028db feat: ensure we inject environment variables into the docker container create call in app-json
This fixes an issue where the values are empty for CNB applications.
2021-02-11 06:43:15 -05:00
Jose Diaz-Gonzalez 0405b36ab4 fix: implement config-export hook
This will allow dropping many of the "source config/functions" calls littered over the codebase. Plugin triggers are the way to perform cross-plugin communication :)
2021-02-11 06:41:11 -05:00
Jose Diaz-Gonzalez 291f59999c Merge pull request #4395 from dokku/cnb-env-vars
Add environment variable support to CNB-based containers
2021-02-11 05:21:31 -05:00
Jose Diaz-Gonzalez 1568fc7827 refactor: only special case cnb for now 2021-02-11 04:21:08 -05:00
Jose Diaz-Gonzalez 681fd6abf6 fix: install pack for tests 2021-02-11 04:04:25 -05:00
Jose Diaz-Gonzalez 031159c1b9 fix: correct dockblock 2021-02-11 04:02:06 -05:00
Jose Diaz-Gonzalez 812e34c6f5 feat: properly export env vars for cnb apps
They are not baked into the image like they are for herokuish, so we need to manually set them via --env. Additionally, due to newline constraints in docker, we need to use `--env=key` format to correctly pull the values into place.
2021-02-11 03:52:02 -05:00
Jose Diaz-Gonzalez 5921692f83 feat: add ability to export env vars as a --env=key ... string 2021-02-11 03:50:51 -05:00
Jose Diaz-Gonzalez 33d5dd44d9 refactor: pull container creation into standalone function
this is necessary for us to be able to inject env vars into the call.
2021-02-11 03:50:08 -05:00
Jose Diaz-Gonzalez d7562d36e6 chore: drop unused destroy 2021-02-11 03:48:42 -05:00
Jose Diaz-Gonzalez 49a2f8ab82 fix: properly specify as argument array 2021-02-11 02:21:43 -05:00
Jose Diaz-Gonzalez 82afae6447 tests: add missing assertion 2021-02-11 02:21:29 -05:00
Jose Diaz-Gonzalez 25ab915883 refactor: standardize on using long-form and equal sign for docker arguments 2021-02-11 02:21:16 -05:00
Jose Diaz-Gonzalez 0963c403ab refactor: simplify container creation call 2021-02-10 11:18:12 -05:00