Commit Graph
33 Commits
Author SHA1 Message Date
Jose Diaz-Gonzalez 9df45f6a6e fix: serialize concurrent property updates
Concurrent commands for the same app could each read a setting, change it, and write it back, so all of them exited successfully while silently dropping changes made by the others. Updates to app settings are now serialized so every change is kept, and readers never see a partially written value.
2026-10-21 21:21:57 -04:00
Jose Diaz-Gonzalez 624eea1959 feat: add registry:auth-status to read back login state
There was no way to ask whether Dokku was already logged in to a registry with a given credential, so tooling converging a declared state onto a server had to re-run `registry:login` on every pass purely to discover that nothing needed to change. The new `registry:auth-status` command compares a supplied credential against the stored one and reports the result through its exit code alone, distinguishing a server with no credential from one whose credential differs, and from one whose secret a docker credential helper or an identity token puts out of reach. An `auth-servers` triad on `registry:report` exposes which servers have credentials without emitting any part of one.
2026-09-19 19:19:57 -04:00
Jose Diaz-Gonzalez 2e3d144aca fix: erase the docker hub credential on registry:logout
Docker stores Docker Hub under the index server address rather than the hostname the user logged in with, and `docker logout` only erases the exact key it is given, so `registry:logout docker.io` reported success while leaving the credential in place. The server is now resolved to the key docker actually stores before the logout runs.
2026-09-19 18:56:46 -04:00
Jose Diaz-Gonzalez bc5acce55e fix: promote registry image-repo-template to app + global
The registry plugin accepted `registry:set <app> image-repo-template <value>` and persisted the per-app file, but only ever read the global value when rendering the image repository, so per-app overrides were silently dropped. The property now follows the same per-app to global to default fallback chain used by `push-on-release` and `server`, and `registry:report` exposes the raw per-app value alongside the existing global and computed flags. The `push-extra-tags` report flags were extended for the same reason: the runtime already honored per-app and global values, but the report only surfaced the raw per-app entry.
2026-05-27 03:23:14 -04:00
Jose Diaz-Gonzalez 9bb766cf17 fix: reference app-specific config.json for retrieving registry auths 2026-01-10 02:33:59 -05:00
Jose Diaz-Gonzalez 6a83fd053c feat: add the ability to log into a registry on a per-app basis
Closes #5324
2026-01-09 00:12:16 -05:00
Naman gandhi 8b07e92391 fix(registry): improve error handling in docker operations
- Replace boolean return values with proper error handling in dockerTag and dockerPush functions
- Add detailed error context including Docker command exit codes and stderr output
- Remove TODO comments and improve error messages for better debugging
- Fix error message formatting in defer function

This addresses the TODO comments for better error handling and provides
users with actionable error information when Docker registry operations fail.

Closes: #XXXX
2025-07-02 01:34:15 -04:00
Krzysztof Taraszka 52b095d7ac fix CI 2024-02-25 22:36:21 +01:00
Krzysztof Taraszka dfa7409486 ah, right, this is not used here 2024-02-25 20:44:56 +01:00
Krzysztof Taraszka ea51db27a2 Merge remote-tracking branch 'origin/master' into feature/add-latest-tag 2024-02-25 20:37:47 +01:00
Krzysztof Taraszka 58fd25ebf4 fun() wrapper is not necessary; removed imagesToRemove array 2024-02-25 20:34:34 +01:00
Krzysztof Taraszka 00925b6c09 use common.RemoveImages 2024-02-25 20:10:04 +01:00
Krzysztof Taraszka 54f74cccd0 anonymous func to run defer in a block 2024-02-25 18:46:45 +01:00
Krzysztof Taraszka 2ad1572080 whops, remove my DEBUG print 2024-02-25 16:26:24 +01:00
Krzysztof Taraszka 881d16ea90 Untag extra image tag 2024-02-25 15:23:27 +01:00
Krzysztof Taraszka dff13a8f1b push based on push-extra-tags list of tags 2024-02-14 18:29:49 +01:00
Jose Diaz-Gonzalez 047a3c00f5 chore: remove default false values when calling CallExecCommand 2024-02-12 20:07:43 -05:00
Jose Diaz-Gonzalez 8a940c6e47 chore: remove all direct usage of go-sh outside of plugin trigger setup
The new way is to use CallExecCommand instead.
2024-02-12 19:29:16 -05:00
Krzysztof Taraszka b6cf0ac410 add latest tag to every latest image dokku push 2024-02-12 14:29:34 +01:00
Jose Diaz-Gonzalez 214dc9b69a feat: add ability to customize the registry repo with a template 2024-01-19 06:29:32 -05:00
Jose Diaz-Gonzalez f90ef17338 fix: trim whitespace on registry property values
When upgrading from an older install of Dokku with the old community registry plugin, newlines could be available in the properties set on disk. Trim them so any usage of the properties continues to work as expected by users.
2023-06-02 19:35:27 -04:00
Jose Diaz-Gonzalez b48b79f5ca feat: allow specifying a single process type to restart
This changes restarts to drop the 'release' part that currently gets triggered, which also helps reduce the possibility that a new image layer will be added due to predeploy deploy triggers.

Note that the old method essentially halfway-rebuilt the app (which was what added the extra layer). This refactor removes that, which is a bc-break.

Additionally, scaling processes will result in deploying _only_ restarting the processes being scaled.

Closes #2184
2021-10-09 18:46:17 -04:00
Jose Diaz-Gonzalez 8f98bbc66f fix: do not append trailing slash on empty server values 2021-08-05 15:17:32 -04:00
Jose Diaz-Gonzalez 0a08911800 fix: do not aggressively clean up when using the docker-local scheduler 2021-08-05 04:17:37 -04:00
Jose Diaz-Gonzalez d727dd76ce fix: ensure we push and cleanup the correct images 2021-08-05 01:13:36 -04:00
Jose Diaz-Gonzalez 9a845664e1 feat: implement image cleanup 2021-08-04 21:49:14 -04:00
Jose Diaz-Gonzalez 1a99271fa8 feat: push tag 2021-08-04 21:49:14 -04:00
Jose Diaz-Gonzalez dc04ab912d feat: tag image 2021-08-04 21:49:14 -04:00
Jose Diaz-Gonzalez 93f819609e feat: filled in more of pushToRegistry 2021-08-04 21:49:14 -04:00
Jose Diaz-Gonzalez b33cd266e7 chore: drop unused code 2021-08-04 21:49:14 -04:00
Jose Diaz-Gonzalez 88cbae2a6d feat: implement more of the registry plugin 2021-08-04 21:49:14 -04:00
Jose Diaz-Gonzalez e68c04b9a6 fix: handle lint issues 2021-08-04 21:49:14 -04:00
Jose Diaz-Gonzalez 5d8340d305 feat: stub out a bunch of code 2021-08-04 21:49:14 -04:00