Commit Graph
17 Commits
Author SHA1 Message Date
Jose Diaz-Gonzalez e715944c86 fix: isolate config tests from the host dokku installation
The config tests wrote to the real `DOKKU_ROOT` and `DOKKU_LIB_ROOT`, including the global `ENV` file, and relied on a `dokku` user and group existing. That held only because the result of applying ownership was discarded; now that it is reported, the tests failed under `ci-go-coverage`, which runs them in a build image that has no `dokku` user. They now use the temporary directories and current-user ownership the migration tests already use.
2026-09-18 01:05:35 -04:00
Jose Diaz-Gonzalez 0c3ae47299 fix: report config write failures instead of exiting 0
`config:set`, `config:unset` and `config:clear` discarded the result of writing the app's environment, so a write that never landed still printed `Setting config vars`, still fired the `post-config-update` trigger, still restarted the app and still exited 0. The `config-set` and `config-unset` plugin triggers behaved the same way, which meant an `app.json` `env` block that could not be persisted deployed anyway with the variables missing. The environment is now staged in a temporary file and renamed into place, so a write that fails partway leaves the previous environment intact, and that file is created at `0600` rather than being created at `0644` and chmodded afterwards. `apps:clone` and `apps:rename` never applied that chmod at all and left the new app's environment world-readable.
2026-09-18 00:36:38 -04:00
Jose Diaz-Gonzalez 4ae48c6ea0 test: pin test-env system identity and core-plugins path
PropertyMap tests went through SetPermissions, which looks up the `dokku` user/group; the fresh `golang:1.26.2` container used by `go-test-plugin-in-docker` has neither, so the chown failed with `unknown group dokku`. Override `DOKKU_SYSTEM_USER` and `DOKKU_SYSTEM_GROUP` to `root` in the property and chart-migration test setups so the chown targets an identity that exists everywhere. The config tests also called `plugn trigger post-config-update` without `PLUGIN_CORE_AVAILABLE_PATH` set, so the hook tried to source `/common/functions` and logged a noisy warning on every test; point the env var at the canonical `/var/lib/dokku/core-plugins/available` location.
2026-05-31 02:23:35 -04:00
Jose Diaz-Gonzalez aa45f748b1 fix: create DOKKU_ROOT app dir in Go tests and set global ENV permissions
- config_test.go: create app dir at DOKKU_ROOT for VerifyAppName and
  ensure global config parent directory exists
- migrateGlobalEnv: set dokku:dokku ownership on global ENV file after
  writing so deploy processes running as dokku can read it
2026-04-27 01:06:32 -04:00
Jose Diaz-Gonzalez 38c6b180af fix: reference env from config dir 2026-04-27 01:05:41 -04:00
Jose Diaz-Gonzalez 97f2dc81c7 fix: simplify tests 2025-11-08 01:22:31 -05:00
Jose Diaz-Gonzalez e134c314ea feat: implement config:import command
Closes #6846
2025-11-08 01:02:19 -05:00
Eng Zer Jun 1d186a5a81 refactor(plugins): replace deprecated io/ioutil functions
The io/ioutil package has been deprecated as of Go 1.16 [1]. This commit
replaces the existing io/ioutil functions with their new definitions in
io and os packages.

[1]: https://golang.org/doc/go1.16#ioutil
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2023-12-22 01:59:22 +08:00
Jose Diaz-Gonzalez b94488f32f fix: set PLUGIN_PATH for golang tests 2022-10-22 15:56:23 -04:00
Jose Diaz-Gonzalez cc9d76aa11 fix: set globally 2022-05-29 00:00:26 -04:00
Jose Diaz-Gonzalez 97bbded5bb tests: set the PLUGIN_ENABLED_PATH for config tests 2022-05-28 23:23:25 -04:00
Jose Diaz-Gonzalez a95e5d210d tests: test the command funcs to exercise app validation 2022-05-28 18:23:34 -04:00
Jose Diaz-Gonzalez f977edabb2 feat: add config:clear command
Closes #3537
2019-05-20 13:26:21 -07:00
Alex Quick afeb521f07 feature: remove bad config vars from envfiles when loaded
resolves: #3036
2018-01-28 17:19:28 -05:00
Alex Quick e7faec3e26 [config] fail on setting/unsetting invalid keys 2017-12-15 09:20:18 -05:00
Alex Quick 91c2164e49 [config] refactor package structure 2017-10-15 20:10:46 -04:00
Michael Hobbs b099d2c389 add more tests 2017-10-02 16:49:54 -07:00