Jose Diaz-Gonzalez
752a0cacd9
fix: clear proxy configs on boot
...
Unfortunately, Docker does not persist container IPs on boot, so containers may come up with the wrong IP, resulting in proxying to the incorrect app after a server restart. Instead, we should delete the configs and let ps:restore rebuild the proxy config correctly.
Closes #3932
2020-09-10 01:58:45 -04:00
Jose Diaz-Gonzalez
ecc6c9e01d
Merge pull request #4129 from dokku/4102-prohibit-non-dns-names
...
Prohibit non-dns names for apps and process types
2020-09-09 23:39:27 -04:00
Jose Diaz-Gonzalez
7e9f98b513
Merge pull request #4080 from hugopeixoto/fix/app-vhost-usage
2020-09-09 21:23:15 -04:00
Jose Diaz-Gonzalez
0f514f300e
feat: prohibit non-dns names for apps and process types
...
This is necessary for ensuring ssl certificates can be auto-retrieved for apps, and also easing integration into schedulers that use names and process types as part of DNS records.
As well, this fixes an issue where we may potentially have invalid DNS entries when adding apps to custom networks.
Closes #4102
Closes #4114
2020-09-09 20:07:50 -04:00
Jose Diaz-Gonzalez
becf7c1f86
feat: allow customizing the various nginx templates
...
This will let custom distributions of Dokku to override the internal templates without needing to repackage Dokku or overwrite core files.
2020-09-06 13:57:35 -04:00
Jose Diaz-Gonzalez
70c947289f
Merge pull request #4121 from dokku/4087-nginx-extract-disable
...
Add ability to disable custom ninx.conf.sigil extraction
2020-09-05 11:48:57 -04:00
fomojola
ab9780d971
Support for expected text with special characters
...
Added a quote around the "$EXPECTED" to deal with text with restricted characters. While deploying a Spring Boot application, the content of the built-in health check is {"status":"UP"}. Unfortunately all my checks failed, because for some reason the comparison didn't like this content.
remote: ! http://localhost/actuator/health : expected to but did not find: "{"status":"UP"}"
remote: ! Check attempt 7/10 failed.
After making this change, it works: I'm assuming the difference is that the presence of the quote characters in the content.
2020-09-04 16:49:47 -04:00
Jose Diaz-Gonzalez
f5ba843cf3
feat: add ability to disable custom ninx.conf.sigil extraction
...
Closes #4087
2020-09-04 11:29:23 -04:00
Jose Diaz-Gonzalez
052f2a5868
Merge pull request #4115 from dokku/4099-image-cleanup
...
Add missing labels to built images
2020-08-31 21:25:55 -04:00
Jose Diaz-Gonzalez
43c521c193
Merge pull request #4117 from dokku/go-app-json
2020-08-31 21:22:21 -04:00
Jose Diaz-Gonzalez
2a1d3877f1
fix: add docblock
2020-08-31 21:03:16 -04:00
Jose Diaz-Gonzalez
4d735b4d88
fix: do not output error on checking for process type existence
2020-08-31 18:55:39 -04:00
Jose Diaz-Gonzalez
b8b6d64f75
fix: correct stickler-ci errors and remove unused code
2020-08-31 18:44:00 -04:00
Jose Diaz-Gonzalez
2b65def123
fix: pass command directly to entrypoint
...
Closes #3706
2020-08-31 18:36:07 -04:00
Jose Diaz-Gonzalez
7fe69fa269
fix: add missing hook
2020-08-31 18:26:36 -04:00
Jose Diaz-Gonzalez
84367e1c16
fix: correctly handle injecting environment variables to deployment tasks
...
Also test that release tasks are invoked the correct environment.
Closes #3817
2020-08-31 15:01:14 -04:00
Michael Chen
5ea4c9a73d
🐛 Whitelist config:clear command in Makefile
2020-08-31 18:28:59 +02:00
Jose Diaz-Gonzalez
428beb3413
fix: pass in correct image variable
2020-08-31 04:23:10 -04:00
Jose Diaz-Gonzalez
9aab7dce7d
feat: create ps directory on app create
2020-08-31 04:22:40 -04:00
Jose Diaz-Gonzalez
2478556df1
fix: ensure the base directory exists before extracting the file
2020-08-31 04:22:27 -04:00
Jose Diaz-Gonzalez
a2d4ba4689
fix: set correct args for fn-procfile-extract
2020-08-31 04:21:59 -04:00
Jose Diaz-Gonzalez
4ab9632526
fix: handle case where there is no app.json
...
Somehow, an empty file may get copied over...
2020-08-31 02:56:50 -04:00
Jose Diaz-Gonzalez
baa819c2a5
fix: add missing labels to built images
...
This fixes an issue where disk space is not recouped after deploys unless 'dokku cleanup' without arguments is called.
Also injects the label-schema labels as necessary.
Refs #4099
2020-08-31 02:37:04 -04:00
Jose Diaz-Gonzalez
aaf8bc811a
chore: drop now unused internal-functions file
2020-08-31 02:33:07 -04:00
Jose Diaz-Gonzalez
53dabf7fd0
refactor: fix handling of string andd array CMD and ENTRYPOINT values
...
Previous versions extracted the values as strings, prefixing the values with `/bin/sh -c '$CMD'` unnecessarily. This caused issues where we would incorrectly overrride these values when an app had a predeploy script.
Closes #3143
2020-08-31 02:31:36 -04:00
Jose Diaz-Gonzalez
7ca4cba8ec
chore: drop extra quotes
2020-08-31 02:06:24 -04:00
Jose Diaz-Gonzalez
5965b70b39
fix: do not log empty messages
2020-08-31 02:05:21 -04:00
Jose Diaz-Gonzalez
23db07ed4e
chore: remove extra LogDebug call
2020-08-31 02:05:03 -04:00
Jose Diaz-Gonzalez
53e75e7898
chore: rewrite log message
...
This change makes it more clear as to what is being executed.
2020-08-31 02:04:51 -04:00
Jose Diaz-Gonzalez
31ab2f97f6
fix: split arguments to ensure they get parsed properly
2020-08-30 16:05:10 -04:00
Jose Diaz-Gonzalez
8126c63d6e
fix: properly handle return from PluginTriggerOutput
2020-08-30 14:51:25 -04:00
Jose Diaz-Gonzalez
6df38a56d1
fix: properly set property...
2020-08-30 14:22:55 -04:00
Jose Diaz-Gonzalez
68debb44f7
refactor: use plugin trigger to delete procfile
2020-08-30 14:22:47 -04:00
Jose Diaz-Gonzalez
f27096f235
refactor: implement appjson in golang
2020-08-30 13:41:15 -04:00
Jose Diaz-Gonzalez
f2a623fde0
fix: trim whitespace to ensure container ID is valid
2020-08-30 13:41:15 -04:00
Jose Diaz-Gonzalez
7ee26d41f7
fix: correct doc
2020-08-30 13:41:15 -04:00
Jose Diaz-Gonzalez
55c77773ab
fix: read input correct as string
2020-08-30 13:41:15 -04:00
Jose Diaz-Gonzalez
147abc5c6b
feat: add LogDebug
2020-08-30 13:41:15 -04:00
Jose Diaz-Gonzalez
e6f2ee6499
fix: handle edge cases during procfile removal
2020-08-30 13:41:15 -04:00
Jose Diaz-Gonzalez
8f671b43ae
feat: add helper functions for getting global config
2020-08-30 13:41:14 -04:00
Jose Diaz-Gonzalez
617ca885f1
fix: run release during predeploy
2020-08-30 13:41:14 -04:00
Jose Diaz-Gonzalez
1813317e86
fix: execute correct script
2020-08-30 13:41:14 -04:00
Jose Diaz-Gonzalez
9bf7ddc258
fix: correct module name
2020-08-30 13:41:14 -04:00
Jose Diaz-Gonzalez
77f211c372
feat: add command for logging container output
2020-08-30 13:41:14 -04:00
Jose Diaz-Gonzalez
1ea60a16e5
refactor: move external procfile manipulation into triggers
...
This also cleans up the internal APIs a bit.
2020-08-30 13:41:14 -04:00
Jose Diaz-Gonzalez
98bc513336
feat: implement getPhaseScript and scaffold out plugin triggers
2020-08-30 13:41:14 -04:00
Jose Diaz-Gonzalez
b6d5d291b0
feat: template out app.json plugin
...
Note: this won't compile as the triggers themselves aren't implemented just yet.
2020-08-30 13:41:14 -04:00
Jose Diaz-Gonzalez
6f6fa709ec
feat: implement common.CopyFromImage
2020-08-30 13:41:14 -04:00
Jose Diaz-Gonzalez
82a6dbf887
fix: correct variable declaration
2020-08-30 13:41:14 -04:00
Jose Diaz-Gonzalez
dee879538c
feat; add common.LogExclaim()
2020-08-30 13:41:14 -04:00