feat: add --volume-options flag to storage:mount
The named-entry form of `storage:mount` had no way to set the attachment's `volume_options`, even though the legacy `host:container:opts` colon form parses options into the same field and every downstream consumer (the docker-args trigger and the storage:list/storage:report display path) already renders them. Tooling that declaratively re-applies attachments silently dropped options on every re-apply.
This commit is contained in:
@@ -38,3 +38,25 @@ func TestRepairRegistryOwnership(t *testing.T) {
|
||||
Expect(os.RemoveAll(RegistryDirectory())).To(Succeed())
|
||||
Expect(repairRegistryOwnership()).To(Succeed())
|
||||
}
|
||||
|
||||
// TestBuildDockerVFlagVolumeOptions covers the rendering rules in
|
||||
// buildDockerVFlag for the various combinations of Readonly and
|
||||
// VolumeOptions. This is the docker-args path that the running
|
||||
// container actually receives.
|
||||
func TestBuildDockerVFlagVolumeOptions(t *testing.T) {
|
||||
RegisterTestingT(t)
|
||||
|
||||
entry := &Entry{HostPath: "/host"}
|
||||
|
||||
plain := buildDockerVFlag(entry, &Attachment{ContainerPath: "/container"})
|
||||
Expect(plain).To(Equal("-v /host:/container"))
|
||||
|
||||
opts := buildDockerVFlag(entry, &Attachment{ContainerPath: "/container", VolumeOptions: "Z"})
|
||||
Expect(opts).To(Equal("-v /host:/container:Z"))
|
||||
|
||||
ro := buildDockerVFlag(entry, &Attachment{ContainerPath: "/container", Readonly: true})
|
||||
Expect(ro).To(Equal("-v /host:/container:ro"))
|
||||
|
||||
roOpts := buildDockerVFlag(entry, &Attachment{ContainerPath: "/container", Readonly: true, VolumeOptions: "noexec,nosuid"})
|
||||
Expect(roOpts).To(Equal("-v /host:/container:ro,noexec,nosuid"))
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user