fix: strip trailing slashes in hostname from web installer

The web installer needs work to add proper validation of input, but for now, this change will ensure folks don't accidentally add an extra slash to the global domain.

Closes #4106

[ci skip]
This commit is contained in:
Jose Diaz-Gonzalez committed 2021-01-18 00:49:52 -05:00
1 parent e64b69248a
commit f45b5bfd5e
1 file changed
+2 -2
+2 -2
View File
@@ -154,7 +154,7 @@ class GetHandler(SimpleHTTPServer.SimpleHTTPRequestHandler):
if 'vhost' in params and params['vhost'].value == 'true': if 'vhost' in params and params['vhost'].value == 'true':
vhost_enable = 'true' vhost_enable = 'true'
with open(vhost_filename, 'w') as f: with open(vhost_filename, 'w') as f:
f.write(params['hostname'].value) f.write(params['hostname'].value.strip("/"))
shutil.chown(vhost_filename, dokku_user, dokku_group) shutil.chown(vhost_filename, dokku_user, dokku_group)
else: else:
try: try:
@@ -165,7 +165,7 @@ class GetHandler(SimpleHTTPServer.SimpleHTTPRequestHandler):
hostname_filename = '{0}/HOSTNAME'.format(dokku_root) hostname_filename = '{0}/HOSTNAME'.format(dokku_root)
with open(hostname_filename, 'w') as f: with open(hostname_filename, 'w') as f:
f.write(params['hostname'].value) f.write(params['hostname'].value.strip("/"))
shutil.chown(hostname_filename, dokku_user, dokku_group) shutil.chown(hostname_filename, dokku_user, dokku_group)