refactor: standardize help generation

plugins/logs/commands

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 [[ " help logs:help " == *" $1 "* ]] || exit "$DOKKU_NOT_IMPLEMENTED_EXIT"
-source "$PLUGIN_AVAILABLE_PATH/logs/internal-functions"
+source "$PLUGIN_AVAILABLE_PATH/logs/help-functions"
 set -eo pipefail
 [[ $DOKKU_TRACE ]] && set -x
 

plugins/logs/help-functions

@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+set -eo pipefail
+[[ $DOKKU_TRACE ]] && set -x
+
+cmd-logs-help() {
+  declare desc="help command"
+  declare CMD="$1"
+  local plugin_name="logs"
+  local plugin_description="Manage log integration for an app"
+
+  if [[ "$CMD" == "$plugin_name:help" ]]; then
+    echo -e "Usage: dokku $plugin_name[:COMMAND]"
+    echo ''
+    echo "$plugin_description"
+    echo ''
+    echo 'Additional commands:'
+    fn-help-content | sort | column -c2 -t -s,
+  elif [[ $(ps -o command= $PPID) == *"--all"* ]]; then
+    fn-help-content
+  else
+    cat <<help_desc
+    $plugin_name, $plugin_description
+help_desc
+  fi
+}
+
+fn-help-content() {
+  declare desc="return help content"
+  cat <<help_content
+    logs <app> [-h] [-t] [-n num] [-q] [-p process], Display recent log output
+    logs:failed <app>, Show the last logs for an application
+help_content
+}

plugins/logs/internal-functions

@@ -12,28 +12,3 @@ fn-logs-usage() {
   echo " -t, --tail           # continually stream logs"
   echo " -q, --quiet          # display raw logs without colors, time and names"
 }
-
-fn-logs-help-content() {
-  declare desc="return logs plugin help content"
-  cat <<help_content
-    logs <app> [-h] [-t] [-n num] [-q] [-p process], Display recent log output
-    logs:failed <app>, Show the last logs for an application
-help_content
-}
-
-cmd-logs-help() {
-  if [[ $1 == "logs:help" ]]; then
-    echo -e 'Usage: dokku logs[:COMMAND]'
-    echo ''
-    echo 'Output app logs'
-    echo ''
-    echo 'Additional commands:'
-    fn-logs-help-content | sort | column -c2 -t -s,
-  elif [[ $(ps -o command= $PPID) == *"--all"* ]]; then
-    fn-logs-help-content
-  else
-    cat <<help_desc
-    logs, Output app logs
-help_desc
-  fi
-}