refactor: standardize help generation

plugins/20_events/commands

@@ -1,30 +1,12 @@
 #!/usr/bin/env bash
 [[ " help events:help " == *" $1 "* ]] || exit "$DOKKU_NOT_IMPLEMENTED_EXIT"
+source "$PLUGIN_AVAILABLE_PATH/20_events/help-functions"
 set -eo pipefail
 [[ $DOKKU_TRACE ]] && set -x
 
 case "$1" in
   help | events:help)
-    help_content_func() {
-      declare desc="return events plugin help content"
-      cat <<help_content
-    events [-t], Show the last events (-t follows)
-    events:list, List logged events
-    events:on, Enable events logger
-    events:off, Disable events logger
-help_content
-    }
-
-    if [[ $1 == "events:help" ]]; then
-      echo 'Usage: dokku events:COMMAND [-t]'
-      echo ''
-      echo 'Interact with Dokku event logger.'
-      echo ''
-      echo 'Additional commands:'
-      help_content_func | sort | column -c2 -t -s,
-    else
-      help_content_func
-    fi
+    cmd-events-help "$@"
     ;;
 
   *)

plugins/20_events/help-functions

@@ -0,0 +1,35 @@
+#!/usr/bin/env bash
+set -eo pipefail
+[[ $DOKKU_TRACE ]] && set -x
+
+cmd-events-help() {
+  declare desc="help command"
+  declare CMD="$1"
+  local plugin_name="events"
+  local plugin_description="Interact with Dokku event logger"
+
+  if [[ "$CMD" == "$plugin_name:help" ]]; then
+    echo -e "Usage: dokku $plugin_name[:COMMAND]"
+    echo ''
+    echo "$plugin_description"
+    echo ''
+    echo 'Additional commands:'
+    fn-help-content | sort | column -c2 -t -s,
+  elif [[ $(ps -o command= $PPID) == *"--all"* ]]; then
+    fn-help-content
+  else
+    cat <<help_desc
+    $plugin_name, $plugin_description
+help_desc
+  fi
+}
+
+fn-help-content() {
+  declare desc="return help content"
+  cat <<help_content
+    events [-t], Show the last events (-t follows)
+    events:list, List logged events
+    events:on, Enable events logger
+    events:off, Disable events logger
+help_content
+}

plugins/20_events/subcommands/list

@@ -14,6 +14,9 @@ cmd-events-list() {
     dokku_col_log_info2_quiet "Events currently logged"
 
     for hook in $logged; do
+      if [[ "$hook" == "help-functions" ]]; then
+        continue
+      fi
       dokku_col_log_msg "$hook"
     done
   else