From ee4fca572e5bf8f30b8b1ea7622796b3b9d37996 Mon Sep 17 00:00:00 2001
From: Michael Hobbs <michaelshanehobbs@gmail.com>
Date: Sun, 12 Jul 2015 15:56:52 -0700
Subject: [PATCH] mv dockerfile port logic to common function + tests. closes
 #1280

---
 plugins/00_dokku-standard/commands |  2 +-
 plugins/common/functions           |  9 +++++++++
 tests/unit/core_ports.bats         | 27 +++++++++++++++++++++++++++
 tests/unit/test_helper.bash        |  1 +
 4 files changed, 38 insertions(+), 1 deletion(-)

diff --git a/plugins/00_dokku-standard/commands b/plugins/00_dokku-standard/commands
index a091783e5..7ec31aa45 100755
--- a/plugins/00_dokku-standard/commands
+++ b/plugins/00_dokku-standard/commands
@@ -36,7 +36,7 @@ case "$1" in
 
       dockerfile)
         # extract first port from Dockerfile
-        DOCKERFILE_PORT=$(grep "^EXPOSE \+[[:digit:]]\+\(\/tcp\)\? *$" Dockerfile | head -1 | sed 's/EXPOSE \+\([[:digit:]]\+\)\(\/tcp\)\?.*/\1/' || true)
+        DOCKERFILE_PORT=$(get_dockerfile_exposed_port Dockerfile)
         [[ -n "$DOCKERFILE_PORT" ]] && dokku config:set-norestart $APP DOKKU_DOCKERFILE_PORT=$DOCKERFILE_PORT
 
         # buildstep pluginhooks don't necessarily make sense for dockerfiles. call the new breed!!!
diff --git a/plugins/common/functions b/plugins/common/functions
index c7afd2bc1..c5d900fc2 100755
--- a/plugins/common/functions
+++ b/plugins/common/functions
@@ -201,3 +201,12 @@ get_container_ids() {
   shopt -u nullglob
   echo $DOKKU_CIDS
 }
+
+get_dockerfile_exposed_port() {
+  local DOCKERFILE_PORT=$(grep "^EXPOSE \+[[:digit:]]\+\(\/tcp\)\? *$" $1 | head -1 | sed 's/EXPOSE \+\([[:digit:]]\+\)\(\/tcp\)\?.*/\1/' || true)
+  if [[ -n "$DOCKERFILE_PORT" ]]; then
+    echo "$DOCKERFILE_PORT"
+  else
+    echo ""
+  fi
+}
diff --git a/tests/unit/core_ports.bats b/tests/unit/core_ports.bats
index 437732b79..1fdf76097 100644
--- a/tests/unit/core_ports.bats
+++ b/tests/unit/core_ports.bats
@@ -5,6 +5,7 @@ load test_helper
 setup() {
   [[ -f "$DOKKU_ROOT/VHOST" ]] && cp -f "$DOKKU_ROOT/VHOST" "$DOKKU_ROOT/VHOST.bak"
   [[ -f "$DOKKU_ROOT/HOSTNAME" ]] && cp -f "$DOKKU_ROOT/HOSTNAME" "$DOKKU_ROOT/HOSTNAME.bak"
+  DOCKERFILE="$BATS_TMPDIR/Dockerfile"
 }
 
 teardown() {
@@ -131,3 +132,29 @@ teardown() {
   echo "status: "$status
   assert_success
 }
+
+@test "(core) port exposure (dockerfile raw port)" {
+  source "$PLUGIN_PATH/common/functions"
+  cat<<EOF > $DOCKERFILE
+EXPOSE 3001/udp
+EXPOSE 3003
+EXPOSE  3000/tcp
+EOF
+  run get_dockerfile_exposed_port $DOCKERFILE
+  echo "output: "$output
+  echo "status: "$status
+  assert_output 3003
+}
+
+@test "(core) port exposure (dockerfile tcp port)" {
+  source "$PLUGIN_PATH/common/functions"
+  cat<<EOF > $DOCKERFILE
+EXPOSE 3001/udp
+EXPOSE  3000/tcp
+EXPOSE 3003
+EOF
+  run get_dockerfile_exposed_port $DOCKERFILE
+  echo "output: "$output
+  echo "status: "$status
+  assert_output 3000
+}
diff --git a/tests/unit/test_helper.bash b/tests/unit/test_helper.bash
index fc4dc443f..9bb6c4ae4 100644
--- a/tests/unit/test_helper.bash
+++ b/tests/unit/test_helper.bash
@@ -2,6 +2,7 @@
 
 # constants
 DOKKU_ROOT=${DOKKU_ROOT:=~dokku}
+PLUGIN_PATH=${PLUGIN_PATH:="/var/lib/dokku/plugins"}
 TEST_APP=my-cool-guy-test-app
 
 # test functions