refactor: warn when invalid cron entries might be written

This commit is contained in:
Jose Diaz-Gonzalez committed 2025-06-19 01:11:29 -04:00
1 parent 776013b0f4
commit ed851fe399
2 files changed
+3 -2

No files matched your search

+1 -1
View File
@@ -90,7 +90,7 @@ func FetchCronEntries(appName string) ([]TemplateCommand, error) {
parser := cronparser.NewParser(cronparser.Minute | cronparser.Hour | cronparser.Dom | cronparser.Month | cronparser.Dow | cronparser.Descriptor) parser := cronparser.NewParser(cronparser.Minute | cronparser.Hour | cronparser.Dom | cronparser.Month | cronparser.Dow | cronparser.Descriptor)
_, err := parser.Parse(c.Schedule) _, err := parser.Parse(c.Schedule)
if err != nil { if err != nil {
return commands, fmt.Errorf("Invalid cron schedule %s: %s", c.Schedule, err.Error()) return commands, fmt.Errorf("Invalid cron schedule for app %s (schedule %s): %s", appName, c.Schedule, err.Error())
} }
commands = append(commands, TemplateCommand{ commands = append(commands, TemplateCommand{
+2 -1
View File
@@ -55,7 +55,8 @@ func generateCronEntries() ([]cron.TemplateCommand, error) {
c, err := cron.FetchCronEntries(appName) c, err := cron.FetchCronEntries(appName)
if err != nil { if err != nil {
results <- []cron.TemplateCommand{} results <- []cron.TemplateCommand{}
return err common.LogWarn(err.Error())
return nil
} }
results <- c results <- c