Merge pull request #5571 from dokku/5568-prop-data-cleanup

Ensure we properly setup all data directories on app install and creation

tests/unit/apps_1.bats

@@ -221,12 +221,21 @@ teardown() {
 }
 
 @test "(apps) apps:rename with tls" {
-  setup_test_tls
-  deploy_app
+  run setup_test_tls
+  echo "output: $output"
+  echo "status: $status"
+  assert_success
+
+  run deploy_app
+  echo "output: $output"
+  echo "status: $status"
+  assert_success
+
   run /bin/bash -c "dokku apps:rename $TEST_APP great-test-name"
   echo "output: $output"
   echo "status: $status"
   assert_success
+
   run /bin/bash -c "dokku --force apps:destroy great-test-name"
   echo "output: $output"
   echo "status: $status"

tests/unit/test_helper.bash

@@ -355,6 +355,10 @@ setup_client_repo() {
 setup_test_tls() {
   local TLS_TYPE="$1"
   local TLS="/home/dokku/$TEST_APP/tls"
+
+  if ! dokku apps:exists "$TEST_APP" >/dev/null 2>&1; then
+    create_app "$TEST_APP"
+  fi
   mkdir -p "$TLS"
 
   case "$TLS_TYPE" in