From eb8347bcc103ac1fe2f8f5332a71cf39bb1053ff Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Tue, 21 May 2019 11:02:24 -0400 Subject: [PATCH] fix: ignore SC2064 Late expansion was causing issues with variables not actually making it into the trap call, resulting in poor cleaning up temp files. --- tests/shellcheck-exclude | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/shellcheck-exclude b/tests/shellcheck-exclude index 57f97bf7d..57fc5acee 100644 --- a/tests/shellcheck-exclude +++ b/tests/shellcheck-exclude @@ -6,6 +6,7 @@ # SC2029 - Note that, unescaped, this expands on the client side - https://github.com/koalaman/shellcheck/wiki/SC2029 # SC2034 - VAR appears unused - https://github.com/koalaman/shellcheck/wiki/SC2034 # SC2046 - Quote this to prevent word splitting - https://github.com/koalaman/shellcheck/wiki/SC2046 +# SC2064 - Use single quotes, otherwise this expands now rather than when signalled. # SC2068 - Double quote array expansions to avoid re-splitting elements - https://github.com/koalaman/shellcheck/wiki/SC2068 # SC2086 - Double quote to prevent globbing and word splitting - https://github.com/koalaman/shellcheck/wiki/SC2086 # SC2119 - Use 'function "$@"' if function's $1 should mean script's $1 - https://github.com/koalaman/shellcheck/wiki/SC2119