github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix: reference SOURCECODE_WORK_DIR in builder core-post-extract

Browse Source 
The builder-dockerfile, builder-lambda, builder-nixpacks, builder-pack and builder-railpack `core-post-extract` triggers assigned `$2` to a local `SOURCECODE_WORK_DIR` but called `pushd "$TMP_WORK_DIR"`, which was unset. Bash 5.2 silently accepted `pushd ""`, so the bug stayed dormant. Bash 5.3 (shipped with Ubuntu 26.04) makes it a hard error and `set -e` aborts the trigger, causing every `git push` to fail with `pushd: null directory`.
This commit is contained in:
Jose Diaz-Gonzalez
2026-05-07 12:39:46 -04:00
parent 368a6999c9
commit eb17a383c6
10 changed files with 120 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tests/unit/builder-pack.bats
View File

@@ -228,6 +228,29 @@ teardown() {
assert_output "['task.py', 'test']"
}
@test "(builder-pack) core-post-extract renames the configured project.toml" {
local TMP_DIR
TMP_DIR="$(mktemp -d "/tmp/dokku-test-builder-pack.XXXXXX")"
trap "rm -rf '$TMP_DIR'" RETURN
echo "" >"$TMP_DIR/project2.toml"
run /bin/bash -c "dokku builder-pack:set $TEST_APP projecttoml-path project2.toml"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "PLUGIN_PATH=$PLUGIN_PATH PLUGIN_AVAILABLE_PATH=$PLUGIN_AVAILABLE_PATH PLUGIN_ENABLED_PATH=$PLUGIN_ENABLED_PATH PLUGIN_CORE_AVAILABLE_PATH=$PLUGIN_CORE_AVAILABLE_PATH DOKKU_LIB_ROOT=$DOKKU_LIB_ROOT $PLUGIN_ENABLED_PATH/builder-pack/core-post-extract $TEST_APP $TMP_DIR HEAD"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "test -f $TMP_DIR/project.toml"
assert_success
run /bin/bash -c "test ! -e $TMP_DIR/project2.toml"
assert_success
}
cron_run_wrapper() {
local APP="$1"
local APP_REPO_DIR="$2"