From e53e8bb59ff351b2443a6141959e35f6aef9e839 Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Sat, 9 Oct 2021 15:06:25 -0400 Subject: [PATCH] fix: register all containers for retirement on app stop This ensures that unused docker images are _also_ removed. While this will mean a `ps:start` requires a rebuild in the case of a force-stop, it ensures we don't have unused images when destroying apps. --- plugins/scheduler-docker-local/scheduler-stop | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/plugins/scheduler-docker-local/scheduler-stop b/plugins/scheduler-docker-local/scheduler-stop index d1f5134c8..32ab1e5ed 100755 --- a/plugins/scheduler-docker-local/scheduler-stop +++ b/plugins/scheduler-docker-local/scheduler-stop @@ -31,6 +31,10 @@ trigger-scheduler-docker-local-scheduler-stop() { local DOKKU_APP_CIDS=$(get_app_container_ids "$APP") if [[ -n "$DOKKU_APP_CIDS" ]]; then + for CID in $DOKKU_APP_CIDS; do + plugn trigger scheduler-register-retired "$APP" "$CID" + done + # shellcheck disable=SC2086 "$DOCKER_BIN" container rm --force $DOKKU_APP_CIDS >/dev/null 2>&1 || true fi