github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: add error message for invalid flags

Browse Source 
Closes #4193
This commit is contained in:
Jose Diaz-Gonzalez
2021-01-18 00:29:10 -05:00
parent 89cc896c27
commit e39a5663bf
2 changed files with 44 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/plugin/subcommands/install
View File

@@ -21,6 +21,12 @@ cmd-plugin-install() {
plugn trigger install plugn trigger install
;; ;;
*) *)
if [[ -n "$FLAG" ]]; then
dokku_log_warn "First argument must be --core or url to plugin"
dokku_log_warn "Valid prefixes: https:, git:, ssh:, file:"
dokku_log_warn "Valid suffixes: .tar.gz, .tgz"
dokku_log_fail "Please retry with valid arguments"
fi
plugn trigger install plugn trigger install
;; ;;
esac esac

38
tests/unit/plugin.bats
View File

@@ -214,6 +214,44 @@ teardown() {
assert_output_contains "dokku" "3" assert_output_contains "dokku" "3"
} }
@test "(plugin) plugin:install [errors]" {
run /bin/bash -c "dokku plugin:install YABBA_DABBA_DOO XXXX YYYY"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "Please retry with valid arguments"
run /bin/bash -c "dokku plugin:install ZXZX --random-flag"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "Please retry with valid arguments"
run /bin/bash -c "dokku plugin:install http://www.example.com/ --random-flag"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "Please retry with valid arguments"
run /bin/bash -c "dokku plugin:install http://www.example.com/gives-a-404"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "Please retry with valid arguments"
run /bin/bash -c "dokku plugin:install http://xxxx/ --random-flag"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "Please retry with valid arguments"
run /bin/bash -c "dokku plugin:install /path/to/nonexistent/dir"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "Please retry with valid arguments"
}
@test "(plugin) plugin:update [errors]" { @test "(plugin) plugin:update [errors]" {
run /bin/bash -c "dokku plugin:install $TEST_PLUGIN_GIT_REPO --name $TEST_PLUGIN_NAME" run /bin/bash -c "dokku plugin:install $TEST_PLUGIN_GIT_REPO --name $TEST_PLUGIN_NAME"
echo "output: $output" echo "output: $output"