fix: ensure all report subcommands exit 0 when there is no app

Closes #7454

plugins/app-json/subcommands.go

@@ -1,6 +1,8 @@
 package appjson
 
 import (
+	"errors"
+
 	"github.com/dokku/dokku/plugins/common"
 )
 
@@ -9,6 +11,10 @@ func CommandReport(appName string, format string, infoFlag string) error {
 	if len(appName) == 0 {
 		apps, err := common.DokkuApps()
 		if err != nil {
+			if errors.Is(err, common.NoAppsExist) {
+				common.LogWarn(err.Error())
+				return nil
+			}
 			return err
 		}
 		for _, appName := range apps {

plugins/apps/subcommands.go

@@ -209,6 +209,10 @@ func CommandReport(appName string, format string, infoFlag string) error {
 	if len(appName) == 0 {
 		apps, err := common.DokkuApps()
 		if err != nil {
+			if errors.Is(err, common.NoAppsExist) {
+				common.LogWarn(err.Error())
+				return nil
+			}
 			return err
 		}
 		for _, appName := range apps {

plugins/builder/subcommands.go

@@ -1,6 +1,8 @@
 package builder
 
 import (
+	"errors"
+
 	"github.com/dokku/dokku/plugins/common"
 )
 
@@ -9,6 +11,10 @@ func CommandReport(appName string, format string, infoFlag string) error {
 	if len(appName) == 0 {
 		apps, err := common.DokkuApps()
 		if err != nil {
+			if errors.Is(err, common.NoAppsExist) {
+				common.LogWarn(err.Error())
+				return nil
+			}
 			return err
 		}
 		for _, appName := range apps {

plugins/buildpacks/subcommands.go

@@ -108,6 +108,10 @@ func CommandReport(appName string, format string, infoFlag string) error {
 	if len(appName) == 0 {
 		apps, err := common.DokkuApps()
 		if err != nil {
+			if errors.Is(err, common.NoAppsExist) {
+				common.LogWarn(err.Error())
+				return nil
+			}
 			return err
 		}
 		for _, appName := range apps {

plugins/common/common.go

@@ -336,7 +336,7 @@ func UnfilteredDokkuApps() ([]string, error) {
 	dokkuRoot := MustGetEnv("DOKKU_ROOT")
 	files, err := os.ReadDir(dokkuRoot)
 	if err != nil {
-		return apps, fmt.Errorf("You haven't deployed any applications yet")
+		return apps, NoAppsExist
 	}
 
 	for _, f := range files {
@@ -351,7 +351,7 @@ func UnfilteredDokkuApps() ([]string, error) {
 	}
 
 	if len(apps) == 0 {
-		return apps, fmt.Errorf("You haven't deployed any applications yet")
+		return apps, NoAppsExist
 	}
 
 	return apps, nil
@@ -653,6 +653,11 @@ func (err *AppDoesNotExist) Error() string {
 	return fmt.Sprintf("App %s does not exist", err.appName)
 }
 
+// NoAppsExist wraps error to include the app name
+// and is used to distinguish between a normal error and an error
+// where the app is missing
+var NoAppsExist = errors.New("You haven't deployed any applications yet")
+
 // VarArgs skips a number of incoming arguments, returning what is left over
 func VarArgs(arguments []string, skip int) []string {
 	if len(arguments) <= skip {

plugins/common/functions.go

@@ -1,7 +1,6 @@
 package common
 
 import (
-	"fmt"
 	"os"
 	"strings"
 )
@@ -33,7 +32,7 @@ func filterApps(apps []string) ([]string, error) {
 	filteredApps = removeEmptyEntries(filteredApps)
 
 	if len(filteredApps) == 0 {
-		return filteredApps, fmt.Errorf("You haven't deployed any applications yet")
+		return filteredApps, NoAppsExist
 	}
 
 	return filteredApps, nil

plugins/cron/subcommands.go

@@ -2,6 +2,7 @@ package cron
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"os"
 
@@ -55,6 +56,10 @@ func CommandReport(appName string, format string, infoFlag string) error {
 	if len(appName) == 0 {
 		apps, err := common.DokkuApps()
 		if err != nil {
+			if errors.Is(err, common.NoAppsExist) {
+				common.LogWarn(err.Error())
+				return nil
+			}
 			return err
 		}
 		for _, appName := range apps {

plugins/logs/subcommands.go

@@ -52,6 +52,10 @@ func CommandReport(appName string, format string, infoFlag string) error {
 	if len(appName) == 0 {
 		apps, err := common.DokkuApps()
 		if err != nil {
+			if errors.Is(err, common.NoAppsExist) {
+				common.LogWarn(err.Error())
+				return nil
+			}
 			return err
 		}
 		for _, appName := range apps {

plugins/network/subcommands.go

@@ -163,6 +163,10 @@ func CommandReport(appName string, format string, infoFlag string) error {
 	if len(appName) == 0 {
 		apps, err := common.DokkuApps()
 		if err != nil {
+			if errors.Is(err, common.NoAppsExist) {
+				common.LogWarn(err.Error())
+				return nil
+			}
 			return err
 		}
 		for _, appName := range apps {

plugins/ports/subcommands.go

@@ -135,6 +135,10 @@ func CommandReport(appName string, format string, infoFlag string) error {
 	if len(appName) == 0 {
 		apps, err := common.DokkuApps()
 		if err != nil {
+			if errors.Is(err, common.NoAppsExist) {
+				common.LogWarn(err.Error())
+				return nil
+			}
 			return err
 		}
 		for _, appName := range apps {

plugins/proxy/subcommands.go

@@ -65,6 +65,10 @@ func CommandReport(appName string, format string, infoFlag string) error {
 	if len(appName) == 0 {
 		apps, err := common.DokkuApps()
 		if err != nil {
+			if errors.Is(err, common.NoAppsExist) {
+				common.LogWarn(err.Error())
+				return nil
+			}
 			return err
 		}
 		for _, appName := range apps {

plugins/ps/subcommands.go

@@ -44,6 +44,10 @@ func CommandReport(appName string, format string, infoFlag string) error {
 	if len(appName) == 0 {
 		apps, err := common.DokkuApps()
 		if err != nil {
+			if errors.Is(err, common.NoAppsExist) {
+				common.LogWarn(err.Error())
+				return nil
+			}
 			return err
 		}
 		for _, appName := range apps {

plugins/registry/subcommands.go

@@ -72,6 +72,10 @@ func CommandReport(appName string, format string, infoFlag string) error {
 	if len(appName) == 0 {
 		apps, err := common.DokkuApps()
 		if err != nil {
+			if errors.Is(err, common.NoAppsExist) {
+				common.LogWarn(err.Error())
+				return nil
+			}
 			return err
 		}
 		for _, appName := range apps {

plugins/resource/subcommands.go

@@ -1,6 +1,8 @@
 package resource
 
 import (
+	"errors"
+
 	"github.com/dokku/dokku/plugins/common"
 )
 
@@ -28,6 +30,10 @@ func CommandReport(appName string, format string, infoFlag string) error {
 	if len(appName) == 0 {
 		apps, err := common.DokkuApps()
 		if err != nil {
+			if errors.Is(err, common.NoAppsExist) {
+				common.LogWarn(err.Error())
+				return nil
+			}
 			return err
 		}
 		for _, appName := range apps {

plugins/scheduler-k3s/subcommands.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"crypto/rand"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"net/url"
 	"os"
@@ -940,6 +941,10 @@ func CommandReport(appName string, format string, infoFlag string) error {
 	if len(appName) == 0 {
 		apps, err := common.DokkuApps()
 		if err != nil {
+			if errors.Is(err, common.NoAppsExist) {
+				common.LogWarn(err.Error())
+				return nil
+			}
 			return err
 		}
 		for _, appName := range apps {

plugins/scheduler/subcommands.go

@@ -1,6 +1,8 @@
 package scheduler
 
 import (
+	"errors"
+
 	"github.com/dokku/dokku/plugins/common"
 )
 
@@ -9,6 +11,10 @@ func CommandReport(appName string, format string, infoFlag string) error {
 	if len(appName) == 0 {
 		apps, err := common.DokkuApps()
 		if err != nil {
+			if errors.Is(err, common.NoAppsExist) {
+				common.LogWarn(err.Error())
+				return nil
+			}
 			return err
 		}
 		for _, appName := range apps {