From ddf470282e9d8c59c76b203c789f76b7f669e12e Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Fri, 24 Apr 2026 05:02:49 -0400 Subject: [PATCH] fix(tests): update config and nginx tests for post-create side effects The config:show and config:export tests now include DOKKU_PROXY_PORT in expected output since ports-configure runs at app creation time. Add sleep before HTTP assertion in nginx-vhosts_13 test to allow nginx async reload to complete. --- tests/unit/config.bats | 10 +++++----- tests/unit/nginx-vhosts_13.bats | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/unit/config.bats b/tests/unit/config.bats index e9bfb1fce..af758b96a 100644 --- a/tests/unit/config.bats +++ b/tests/unit/config.bats @@ -506,7 +506,7 @@ teardown() { run /bin/bash -c "dokku --app $TEST_APP config:show" echo "output: $output" echo "status: $status" - assert_output "=====> $TEST_APP env vars"$'\nBKEY: true\naKey: true\nbKey: true\nzKey: true' + assert_output "=====> $TEST_APP env vars"$'\nBKEY: true\nDOKKU_PROXY_PORT: 80\naKey: true\nbKey: true\nzKey: true' } @test "(config) config:export" { @@ -518,20 +518,20 @@ teardown() { run /bin/bash -c "dokku config:export --format docker-args $TEST_APP" echo "output: $output" echo "status: $status" - assert_output "--env=BKEY='true' --env=aKey='true' --env=bKey='true' --env=zKey='true'" + assert_output "--env=BKEY='true' --env=DOKKU_PROXY_PORT='80' --env=aKey='true' --env=bKey='true' --env=zKey='true'" run /bin/bash -c "dokku config:export --format shell $TEST_APP" echo "output: $output" echo "status: $status" - assert_output "BKEY='true' aKey='true' bKey='true' zKey='true' " + assert_output "BKEY='true' DOKKU_PROXY_PORT='80' aKey='true' bKey='true' zKey='true' " run /bin/bash -c "dokku config:export --format json $TEST_APP" echo "output: $output" echo "status: $status" - assert_output '{"BKEY":"true","aKey":"true","bKey":"true","zKey":"true"}' + assert_output '{"BKEY":"true","DOKKU_PROXY_PORT":"80","aKey":"true","bKey":"true","zKey":"true"}' run /bin/bash -c "dokku config:export --format json-list $TEST_APP" echo "output: $output" echo "status: $status" - assert_output '[{"name":"BKEY","value":"true"},{"name":"aKey","value":"true"},{"name":"bKey","value":"true"},{"name":"zKey","value":"true"}]' + assert_output '[{"name":"BKEY","value":"true"},{"name":"DOKKU_PROXY_PORT","value":"80"},{"name":"aKey","value":"true"},{"name":"bKey","value":"true"},{"name":"zKey","value":"true"}]' } diff --git a/tests/unit/nginx-vhosts_13.bats b/tests/unit/nginx-vhosts_13.bats index 049e1f46c..37845e6fc 100644 --- a/tests/unit/nginx-vhosts_13.bats +++ b/tests/unit/nginx-vhosts_13.bats @@ -36,6 +36,7 @@ teardown() { echo "output: $output" echo "status: $status" assert_success + sleep 2 assert_http_localhost_response "http" "${TEST_APP}.${DOKKU_DOMAIN}" "80" "/" "" "502" }