fix: discard the build record git:sync starts when nothing is built

cmd-git-sync calls dokku_setup_build_capture before the clone/fetch,
because it cannot know whether there is anything to deploy until it has
fetched. Both paths that then decline to build - a plain `git:sync` with
no build flag, and a `--build-if-changes` poll that finds the remote
unchanged - returned without ever finalizing that record.

The record stayed at status=running forever, which has three
consequences on an app polled on a timer:

- PruneAppBuilds only runs from builds-record-finalize, so nothing
  prunes the ticks while the app is idle; they accumulate without bound,
  invisibly, because builds:list caps output at the retention count.
- The next real deploy's ReapAbandonedBuilds finalizes each of them as
  status=failed, exit_code=-1, with finished_at stamped at the moment of
  reaping - indistinguishable on disk from a build that really failed,
  and with a duration that grew to the polling interval.
- That same deploy's prune then keeps the newest records by started_at,
  which after an idle stretch are the ticks, deleting the last real
  deploy's record and log.

Add a builds-record-discard trigger that removes a non-terminal record
and its log, and call it from both no-op paths in cmd-git-sync. The
trigger leaves missing and already-terminal records alone, so it can
never delete real history.

Fixes #9030

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Martin VysnyandClaude Opus 5 committed 2026-09-11 17:00:39 +03:00
1 parent aa39920cc7
commit dc27668e09
10 files changed
+188 -1

No files matched your search

+17
View File
@@ -96,6 +96,23 @@ func TriggerBuildsRecordStart(appName, buildID, pidStr, sourceStr string) error
return WriteBuild(b)
}
// TriggerBuildsRecordDiscard drops a record that was started before the caller
// knew whether it would build anything - the git:sync no-op paths, which fetch
// first and only then discover there is nothing to deploy. Records that are
// missing or already terminal are left alone.
//
// Args: <app> <build-id>
func TriggerBuildsRecordDiscard(appName, buildID string) error {
if appName == "" {
return errors.New("builds-record-discard: missing app name")
}
if buildID == "" {
return errors.New("builds-record-discard: missing build id")
}
return DiscardBuild(appName, buildID)
}
// TriggerBuildsRecordFinalize writes the terminal status onto an existing
// build record. It is idempotent: records that are already terminal (or have
// been overwritten by an earlier finalize) are left untouched.