github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

refactor: bubble up error handling so that standard exit codes can be set at the top-level

Browse Source 
LogFail shouldn't be called internally if at all possible.
This commit is contained in:
Jose Diaz-Gonzalez
2021-02-03 04:29:57 -05:00
parent ccdbaa84f9
commit d09a7506df
26 changed files with 113 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/config/src/subcommands/subcommands.go
View File

@@ -105,7 +105,7 @@ func main() {
keys := getKeys(args.Args(), *global)
err = config.CommandUnset(appName, keys, *global, *noRestart)
default:
common.LogFail(fmt.Sprintf("Invalid plugin subcommand call: %s", subcommand))
err = fmt.Errorf("Invalid plugin subcommand call: %s", subcommand)
}
if err != nil {

6
plugins/config/src/triggers/triggers.go
View File

@@ -27,12 +27,12 @@ func main() {
case "config-get":
appName := flag.Arg(0)
key := flag.Arg(1)
config.TriggerConfigGet(appName, key)
err = config.TriggerConfigGet(appName, key)
case "config-get-global":
key := flag.Arg(0)
config.TriggerConfigGetGlobal(key)
err = config.TriggerConfigGetGlobal(key)
default:
common.LogFail(fmt.Sprintf("Invalid plugin trigger call: %s", trigger))
err = fmt.Errorf("Invalid plugin trigger call: %s", trigger)
}
if err != nil {