fix: accept all docker memory units in resource values

Memory values with uppercase or other docker-supported units such as `1G`, `512M` or `1GiB` are now passed to docker unchanged instead of having an extra `m` appended, and the k3s scheduler interprets memory values with the same binary units so a value means the same thing on both schedulers. Invalid `--memory` and `--memory-swap` values are now rejected by `resource:limit` and `resource:reserve`. Closes #9153.
This commit is contained in:
Jose Diaz-Gonzalez committed 2026-10-21 14:07:00 -04:00
1 parent fa0f031560
commit c8e28c2445
13 files changed
+382 -30

No files matched your search

+16
View File
@@ -59,6 +59,22 @@ teardown() {
echo "status: $status"
assert_output "536870912"
run /bin/bash -c "dokku resource:limit --memory 1G $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "dokku ps:rebuild $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_success
CID=$(<$DOKKU_ROOT/$TEST_APP/CONTAINER.web.1)
run /bin/bash -c "docker inspect --format '{{.HostConfig.Memory}}' $CID"
echo "output: $output"
echo "status: $status"
assert_output "1073741824"
run /bin/bash -c "dokku resource:limit --memory 512 $TEST_APP"
echo "output: $output"
echo "status: $status"
+77
View File
@@ -131,3 +131,80 @@ teardown() {
echo "status: $status"
assert_failure
}
@test "(resource) resource:limit uppercase memory units" {
run /bin/bash -c "dokku resource:limit --memory 1G --memory-swap 2G $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "dokku resource:reserve --memory 512M $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_success
run_plugin_script resource docker-args-process-deploy "$TEST_APP" herokuish "dokku/$TEST_APP:latest" web "< /dev/null"
echo "output: $output"
echo "status: $status"
assert_success
assert_output_contains "--memory=1G "
assert_output_contains "--memory-swap=2G "
assert_output_contains "--memory-reservation=512M "
assert_output_not_contains "1Gm"
assert_output_not_contains "512Mm"
run /bin/bash -c "dokku resource:limit --memory 1G --process-type build $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_success
run_plugn_trigger docker-args-process-build "$TEST_APP" herokuish
echo "output: $output"
echo "status: $status"
assert_success
assert_output_contains "--memory=1G "
assert_output_not_contains "1Gm"
}
@test "(resource) resource:limit rejects invalid memory values" {
run /bin/bash -c "dokku resource:limit --memory '100G --foo' $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_failure
run /bin/bash -c "dokku resource:limit --memory 1x $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_failure
run /bin/bash -c "dokku resource:limit --memory-swap 1x $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_failure
run /bin/bash -c "dokku resource:reserve --memory 1Gm $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_failure
run /bin/bash -c "dokku resource:report --resource-_default_.limit.memory $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_failure
run /bin/bash -c "dokku resource:report --resource-_default_.reserve.memory $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_failure
run /bin/bash -c "dokku resource:limit --memory-swap -1 $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "dokku resource:report --resource-_default_.limit.memory-swap $TEST_APP"
echo "output: $output"
echo "status: $status"
assert_success
assert_output "-1"
}