refactor: move host-crontab generation into cron plugin
Host-crontab generation for `app.json` cron tasks now lives in the `cron` plugin, gated by a new `scheduler-uses-host-cron` trigger that the `docker-local` scheduler answers true while self-managed schedulers such as `k3s` answer false. This lets any host-cron scheduler participate in normal `app.json` cron without coupling to `scheduler-docker-local` or duplicating the crontab writer, while the `k3s` scheduler continues to manage its own in-cluster cron jobs. Closes #8862.
This commit is contained in:
@@ -98,11 +98,43 @@ func TriggerPostDelete(appName string) error {
|
||||
return nil
|
||||
}
|
||||
|
||||
// TriggerSchedulerStop stops the scheduler for a given app container
|
||||
func TriggerSchedulerStop(scheduler string, appName string, removeContainers string) error {
|
||||
if scheduler != "docker-local" {
|
||||
// TriggerPostDeploy regenerates the cron schedule for a given app after it is
|
||||
// deployed. Dispatching scheduler-cron-write lets the cron plugin regenerate the
|
||||
// host crontab for host-cron schedulers while self-managed schedulers update
|
||||
// their own backends.
|
||||
func TriggerPostDeploy(appName string) error {
|
||||
scheduler := common.GetAppScheduler(appName)
|
||||
_, err := common.CallPlugnTrigger(common.PlugnTriggerInput{
|
||||
Trigger: "scheduler-cron-write",
|
||||
Args: []string{scheduler, appName},
|
||||
StreamStdio: true,
|
||||
})
|
||||
return err
|
||||
}
|
||||
|
||||
// TriggerSchedulerCronWrite regenerates the host crontab when no scheduler is
|
||||
// given (the letsencrypt "all apps" path) or when the given scheduler uses the
|
||||
// host crontab. Self-managed schedulers implement their own scheduler-cron-write
|
||||
// trigger and are no-ops here.
|
||||
func TriggerSchedulerCronWrite(scheduler string, appName string) error {
|
||||
if scheduler != "" && !usesHostCron(scheduler) {
|
||||
return nil
|
||||
}
|
||||
|
||||
return nil
|
||||
return writeCronTab()
|
||||
}
|
||||
|
||||
// TriggerSchedulerStop regenerates the host crontab for a host-cron app after
|
||||
// its processes are stopped
|
||||
func TriggerSchedulerStop(scheduler string, appName string, removeContainers string) error {
|
||||
if !usesHostCron(scheduler) {
|
||||
return nil
|
||||
}
|
||||
|
||||
_, err := common.CallPlugnTrigger(common.PlugnTriggerInput{
|
||||
Trigger: "scheduler-cron-write",
|
||||
Args: []string{scheduler, appName},
|
||||
StreamStdio: true,
|
||||
})
|
||||
return err
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user