refactor: set deploy-source and metadata at deploy time

This ensures the value is correct, where previously it was computed based on a file - and therefore did not distinguish between git:from-archive and git:from-image.

Closes #4464

plugins/apps/triggers.go

@@ -1,6 +1,8 @@
 package apps
 
 import (
+	"fmt"
+
 	"github.com/dokku/dokku/plugins/common"
 )
 
@@ -24,15 +26,59 @@ func TriggerAppMaybeCreate(appName string) error {
 	return maybeCreateApp(appName)
 }
 
+// TriggerDeploySourceSet sets the current deploy source
+func TriggerDeploySourceSet(appName string, sourceType string, sourceMetadata string) error {
+	if err := common.PropertyWrite("apps", appName, "deploy-source", sourceType); err != nil {
+		return err
+	}
+
+	return common.PropertyWrite("apps", appName, "deploy-source-metadata", sourceMetadata)
+}
+
+// TriggerInstall runs the install step for the apps plugin
+func TriggerInstall() error {
+	if err := common.PropertySetup("apps"); err != nil {
+		return fmt.Errorf("Unable to install the apps plugin: %s", err.Error())
+	}
+
+	return nil
+}
+
+// TriggerPostAppCloneSetup creates new apps files
+func TriggerPostAppCloneSetup(oldAppName string, newAppName string) error {
+	err := common.PropertyClone("apps", oldAppName, newAppName)
+	if err != nil {
+		return err
+	}
+
+	return nil
+}
+
+// TriggerPostAppRenameSetup renames apps files
+func TriggerPostAppRenameSetup(oldAppName string, newAppName string) error {
+	if err := common.PropertyClone("apps", oldAppName, newAppName); err != nil {
+		return err
+	}
+
+	if err := common.PropertyDestroy("apps", oldAppName); err != nil {
+		return err
+	}
+
+	return nil
+}
+
 // TriggerPostDelete is the apps post-delete plugin trigger
 func TriggerPostDelete(appName string) error {
-	imageRepo := common.GetAppImageRepo(appName)
+	if err := common.PropertyDestroy("apps", appName); err != nil {
+		common.LogWarn(err.Error())
+	}
 
 	imagesByAppLabel, err := listImagesByAppLabel(appName)
 	if err != nil {
 		common.LogWarn(err.Error())
 	}
 
+	imageRepo := common.GetAppImageRepo(appName)
 	imagesByRepo, err := listImagesByImageRepo(imageRepo)
 	if err != nil {
 		common.LogWarn(err.Error())