From bdbd295a02ec8f2429a735ab9d58646571617d95 Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Sun, 25 Jan 2026 22:58:10 -0500 Subject: [PATCH] fix: ensure we can call storage:report properly Closes #8275 --- plugins/storage/report.go | 2 +- .../storage/src/subcommands/subcommands.go | 4 +- tests/unit/report.bats | 59 +++++++++++++++++++ 3 files changed, 62 insertions(+), 3 deletions(-) diff --git a/plugins/storage/report.go b/plugins/storage/report.go index d932422e0..cdb46a3d5 100644 --- a/plugins/storage/report.go +++ b/plugins/storage/report.go @@ -2,7 +2,7 @@ package storage import "github.com/dokku/dokku/plugins/common" -func ReportSingleApp(appName string, infoFlag string, format string) error { +func ReportSingleApp(appName string, format string, infoFlag string) error { if err := common.VerifyAppName(appName); err != nil { return err } diff --git a/plugins/storage/src/subcommands/subcommands.go b/plugins/storage/src/subcommands/subcommands.go index 1939564a6..87f00c831 100644 --- a/plugins/storage/src/subcommands/subcommands.go +++ b/plugins/storage/src/subcommands/subcommands.go @@ -38,9 +38,9 @@ func main() { mountPath := args.Arg(1) err = storage.CommandMount(appName, mountPath) case "report": - args := flag.NewFlagSet("scheduler-k3s:report", flag.ExitOnError) + args := flag.NewFlagSet("storage:report", flag.ExitOnError) format := args.String("format", "stdout", "format: [ stdout | json ]") - osArgs, infoFlag, flagErr := common.ParseReportArgs("scheduler-k3s", os.Args[2:]) + osArgs, infoFlag, flagErr := common.ParseReportArgs("storage", os.Args[2:]) if flagErr == nil { args.Parse(osArgs) appName := args.Arg(0) diff --git a/tests/unit/report.bats b/tests/unit/report.bats index 719af8c80..7eea94310 100644 --- a/tests/unit/report.bats +++ b/tests/unit/report.bats @@ -138,3 +138,62 @@ teardown() { assert_output_contains "You haven't deployed any applications yet" done } + +@test "(report) storage report when apps exist" { + run create_app + echo "output: $output" + echo "status: $status" + assert_success + + run /bin/bash -c "dokku report $TEST_APP" + echo "output: $output" + echo "status: $status" + assert_success + + plugins=( + app-json + apps + builder + builder-dockerfile + builder-herokuish + builder-lambda + builder-nixpacks + builder-railpack + builder-pack + buildpacks + caddy + certs + checks + cron + docker-options + domains + git + haproxy + logs + network + nginx + openresty + ports + proxy + ps + registry + resource + scheduler + scheduler-docker-local + scheduler-k3s + storage + traefik + ) + + for plugin in "${plugins[@]}"; do + run /bin/bash -c "dokku $plugin:report 2>&1" + echo "output: $output" + echo "status: $status" + assert_success + + run /bin/bash -c "dokku $plugin:report $TEST_APP 2>&1" + echo "output: $output" + echo "status: $status" + assert_success + done +}