From 33800e226a7576914101d9a00894c580e180b364 Mon Sep 17 00:00:00 2001 From: Tan Jay Jun Date: Wed, 30 Jan 2019 01:45:37 +0800 Subject: [PATCH 1/2] Add warning about PORT variable in deploy tutorial --- docs/deployment/application-deployment.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/deployment/application-deployment.md b/docs/deployment/application-deployment.md index 76d0a44ed..f3aa1e149 100644 --- a/docs/deployment/application-deployment.md +++ b/docs/deployment/application-deployment.md @@ -52,6 +52,9 @@ dokku postgres:link rails-database ruby-rails-sample ### Deploy the app +> Warning: Your application _must_ respect the `PORT` environment variable or it may not respond to web requests. +> Please see the [port management documentation](/docs/networking/port-management.md) for details. + Now you can deploy the `ruby-rails-sample` app to your Dokku server. All you have to do is add a remote to name the app. Applications are created on-the-fly on the Dokku server. ```shell From c368cc0855f4e6f904be11f1e1875ba3a71c5338 Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Tue, 29 Jan 2019 12:57:07 -0500 Subject: [PATCH 2/2] docs: must to should Must is a bit too strong - its possible that the app responds to web requests, just on a different port... [ci skip] --- docs/deployment/application-deployment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/deployment/application-deployment.md b/docs/deployment/application-deployment.md index f3aa1e149..4dfa37412 100644 --- a/docs/deployment/application-deployment.md +++ b/docs/deployment/application-deployment.md @@ -52,7 +52,7 @@ dokku postgres:link rails-database ruby-rails-sample ### Deploy the app -> Warning: Your application _must_ respect the `PORT` environment variable or it may not respond to web requests. +> Warning: Your application _should_ respect the `PORT` environment variable or it may not respond to web requests. > Please see the [port management documentation](/docs/networking/port-management.md) for details. Now you can deploy the `ruby-rails-sample` app to your Dokku server. All you have to do is add a remote to name the app. Applications are created on-the-fly on the Dokku server.