fix: do not attempt to attach a network to a container that already has it

This avoids issues when scaling unrelated process types or if the user has specified the same network at different phases.

Closes #5352
This commit is contained in:
Jose Diaz-Gonzalez
2022-11-06 18:30:05 -05:00
parent 0f8d4a5b38
commit aa49df4fe4
2 changed files with 80 additions and 0 deletions

View File

@@ -242,6 +242,53 @@ teardown() {
assert_success
}
@test "(network) dont re-attach to network" {
run /bin/bash -c "dokku network:create deploy-network"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "dokku network:set $TEST_APP attach-post-deploy deploy-network"
echo "output: $output"
echo "status: $status"
assert_success
run deploy_app dockerfile-procfile
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "dokku ps:scale $TEST_APP worker=1"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "dokku ps:scale $TEST_APP web=3"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "docker container inspect $TEST_APP.web.1"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "docker container inspect $TEST_APP.web.2"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "docker container inspect $TEST_APP.web.3"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "docker container inspect $TEST_APP.worker.1"
echo "output: $output"
echo "status: $status"
assert_success
}
@test "(network) handle single-udp app" {
run /bin/bash -c "dokku docker-options:add $TEST_APP -p 1194:1194"
echo "output: $output"