more style/function tweaks

plugins/ps/functions

@@ -44,7 +44,7 @@ generate_scale_file() {
   if [[ ! -f $DOKKU_SCALE_FILE ]]; then
     dokku_log_info1_quiet "DOKKU_SCALE file not found in app image. Generating one based on Procfile..."
 
-    TMP_WORK_DIR=$(mktemp -d -t "dokku_scale.XXXX")
+    local TMP_WORK_DIR=$(mktemp -d -t "dokku_scale.XXXX")
     trap 'rm -rf "$TMP_WORK_DIR" > /dev/null' RETURN
 
     if [[ -f $DOKKU_PROCFILE ]]; then
@@ -52,8 +52,8 @@ generate_scale_file() {
         if [[ -z "$line" ]] || [[ "$line" == "#"* ]]; then
           continue
         fi
-        NAME=${line%%:*}
-        NUM_PROCS=0
+        local NAME=${line%%:*}
+        local NUM_PROCS=0
         [[ "$NAME" == "web" ]] && NUM_PROCS=1
         [[ -n "$NAME" ]] && echo "$NAME=$NUM_PROCS" >> "$DOKKU_SCALE_FILE"
       done < "$DOKKU_PROCFILE"
@@ -73,8 +73,8 @@ set_scale() {
   shift 1
   local SCALE_SETTINGS=("$@")
   for procscale in "${SCALE_SETTINGS[@]}"; do
-    PROC_NAME=${procscale%%=*}
-    PROC_COUNT=${procscale#*=}
+    local PROC_NAME=${procscale%%=*}
+    local PROC_COUNT=${procscale#*=}
     is_number $PROC_COUNT || dokku_log_fail "ps:scale $PROC_COUNT is not a number"
     dokku_log_info1_quiet "Scaling $APP:$PROC_NAME to $PROC_COUNT"
     if (egrep -q ^${PROC_NAME}= "$DOKKU_SCALE_FILE" > /dev/null 2>&1); then
@@ -147,8 +147,8 @@ ps_scale() {
     dokku_col_log_info1_quiet "--------" "---"
     while read -r line || [[ -n "$line" ]]; do
       [[ -z "$line" ]] && continue
-      PROC_NAME=${line%%=*}
-      PROC_COUNT=${line#*=}
+      local PROC_NAME=${line%%=*}
+      local PROC_COUNT=${line#*=}
       dokku_col_log_info1 "$PROC_NAME" "$PROC_COUNT"
     done < "$DOKKU_SCALE_FILE"
   else