github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

feat: simplify flag parsing in repo plugin

Browse Source 
Commands should be written such that they take arguments as is.
This commit is contained in:
Jose Diaz-Gonzalez
2020-05-28 20:33:07 -04:00
parent 91a668ee8f
commit a60467cb2d
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
plugins/repo/src/subcommands/subcommands.go
View File

@@ -14,16 +14,18 @@ import (
func main() { func main() {
parts := strings.Split(os.Args[0], "/") parts := strings.Split(os.Args[0], "/")
subcommand := parts[len(parts)-1] subcommand := parts[len(parts)-1]
flag.Parse()
var err error var err error
switch subcommand { switch subcommand {
case "gc": case "gc":
flag.Parse() args := flag.NewFlagSet("repo:gc", flag.ExitOnError)
appName := flag.Arg(1) args.Parse(os.Args[2:])
appName := args.Arg(0)
err = repo.CommandGc(appName) err = repo.CommandGc(appName)
case "purge-cache": case "purge-cache":
appName := flag.Arg(1) args := flag.NewFlagSet("repo:purge-cache", flag.ExitOnError)
args.Parse(os.Args[2:])
appName := args.Arg(0)
err = repo.CommandPurgeCache(appName) err = repo.CommandPurgeCache(appName)
default: default:
common.LogFail(fmt.Sprintf("Invalid plugin subcommand call: %s", subcommand)) common.LogFail(fmt.Sprintf("Invalid plugin subcommand call: %s", subcommand))