github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #8691 from dokku/8687-drop-plugin-prefix-from-report-format-json-keys-align-go-plugins-with-bash-strip

Browse Source 
Align Go-plugin :report JSON keys with bash-strip convention
This commit is contained in:
Jose Diaz-Gonzalez
2026-05-27 13:33:49 -04:00
committed by GitHub
parent d635a49d6f 3bf6c72451
commit a5603744ab
48 changed files with 928 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
tests/unit/network.bats
View File

@@ -48,12 +48,24 @@ teardown() {
assert_success
assert_output "dokku.test"
run /bin/bash -c "dokku network:report --global --format json | jq -r '.\"global-tld\"'"
echo "output: $output"
echo "status: $status"
assert_success
assert_output "dokku.test"
run /bin/bash -c "dokku network:report --global --format json | jq -r 'has(\"network-tld\")'"
echo "output: $output"
echo "status: $status"
assert_success
assert_output "false"
run /bin/bash -c "dokku network:report --global --format json | jq -r 'has(\"tld\")'"
echo "output: $output"
echo "status: $status"
assert_success
assert_output "false"
run /bin/bash -c "dokku network:report --global"
echo "output: $output"
echo "status: $status"
@@ -66,6 +78,24 @@ teardown() {
assert_success
}
@test "(network:report) emits new stripped JSON keys alongside legacy" {
run /bin/bash -c "dokku network:report --global --format json | jq -r 'has(\"global-tld\") and has(\"network-global-tld\")'"
assert_success
assert_output "true"
run /bin/bash -c "dokku network:report --global --format json | jq -r 'has(\"computed-tld\") and has(\"network-computed-tld\")'"
assert_success
assert_output "true"
run /bin/bash -c "dokku network:report $TEST_APP --format json | jq -r 'has(\"tld\") and has(\"network-tld\")'"
assert_success
assert_output "true"
run /bin/bash -c "dokku network:report $TEST_APP --format json | jq -r 'has(\"web-listeners\") and has(\"network-web-listeners\")'"
assert_success
assert_output "true"
}
@test "(network:report) tld raw vs computed" {
run /bin/bash -c "dokku network:set --global tld"
echo "output: $output"