fix: validate app name in app-scoped commands

This commit is contained in:
Jose Diaz-Gonzalez committed 2026-09-24 18:14:53 -04:00
1 parent 114c6115b9
commit a4484d354b
22 files changed
+213 -35

No files matched your search

+13
View File
@@ -82,3 +82,16 @@ teardown() {
assert_success
assert_output "false"
}
@test "(caddy:set) missing app" {
run /bin/bash -c "dokku caddy:set missing-app tls-internal true"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "App missing-app does not exist"
run /bin/bash -c "test -e $DOKKU_LIB_ROOT/config/caddy/missing-app"
echo "output: $output"
echo "status: $status"
assert_failure
}
+8
View File
@@ -194,3 +194,11 @@ teardown() {
assert_success
assert_output "--label=a=b"
}
@test "(core) cleanup missing app" {
run /bin/bash -c "dokku cleanup missing-app"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "App missing-app does not exist"
}
+14
View File
@@ -136,6 +136,20 @@ teardown() {
assert_failure
}
@test "(domains) domains:enable and domains:disable (missing app)" {
run /bin/bash -c "dokku domains:disable missing-app"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "App missing-app does not exist"
run /bin/bash -c "dokku domains:enable missing-app"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "App missing-app does not exist"
}
@test "(domains) domains:remove" {
run /bin/bash -c "dokku domains:add $TEST_APP test.app.${DOKKU_DOMAIN}"
echo "output: $output"
+13
View File
@@ -698,3 +698,16 @@ teardown() {
assert_output_contains "Attempting pre-flight checks" 0
assert_output_contains "Application deployed"
}
@test "(network:rebuild) missing app" {
run /bin/bash -c "dokku network:rebuild missing-app"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "App missing-app does not exist"
run /bin/bash -c "test -e $DOKKU_LIB_ROOT/config/common/missing-app"
echo "output: $output"
echo "status: $status"
assert_failure
}
+13
View File
@@ -107,3 +107,16 @@ assert_nginx_property_set_get() {
assert_nginx_property_set_get "nginx-conf-sigil-path" "custom.sigil" "global.sigil"
assert_nginx_property_set_get "nginx-service-command" "/usr/sbin/nginx-app" "/usr/sbin/nginx-global"
}
@test "(nginx:set) missing app" {
run /bin/bash -c "dokku nginx:set missing-app hsts false"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "App missing-app does not exist"
run /bin/bash -c "test -e $DOKKU_LIB_ROOT/config/nginx/missing-app"
echo "output: $output"
echo "status: $status"
assert_failure
}
+13
View File
@@ -82,3 +82,16 @@ teardown() {
assert_success
assert_output "5m"
}
@test "(openresty:set) missing app" {
run /bin/bash -c "dokku openresty:set missing-app client-max-body-size 5m"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "App missing-app does not exist"
run /bin/bash -c "test -e $DOKKU_LIB_ROOT/config/openresty/missing-app"
echo "output: $output"
echo "status: $status"
assert_failure
}
+8
View File
@@ -92,3 +92,11 @@ teardown() {
echo "status: $status"
assert_output "console: 0"
}
@test "(ps:retire) missing app" {
run /bin/bash -c "dokku ps:retire missing-app"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "App missing-app does not exist"
}
+53
View File
@@ -8,6 +8,7 @@ setup() {
}
teardown() {
docker container rm -f "$TEST_APP.run.9999" >/dev/null 2>&1 || true
destroy_app
global_teardown
}
@@ -157,6 +158,58 @@ teardown() {
assert_output "2"
}
@test "(run:stop) only stops run containers for the app" {
run deploy_app
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "dokku run:detached $TEST_APP sleep 300"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "dokku run:list $TEST_APP --format json | jq -r '.[0].name'"
echo "output: $output"
echo "status: $status"
assert_success
local RUN_CONTAINER="$output"
run /bin/bash -c "docker container run -d --name $TEST_APP.run.9999 --entrypoint sleep dokku/$TEST_APP:latest 300"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "dokku run:stop $TEST_APP --container other-app.run.1"
echo "output: $output"
echo "status: $status"
assert_failure
assert_output_contains "Specified app does not match app in container name"
run /bin/bash -c "dokku run:stop $TEST_APP --container $TEST_APP.run.9999"
echo "output: $output"
echo "status: $status"
assert_success
assert_output_contains "Specified container does not exist"
run /bin/bash -c "docker container inspect -f '{{.State.Running}}' $TEST_APP.run.9999"
echo "output: $output"
echo "status: $status"
assert_success
assert_output "true"
run /bin/bash -c "dokku run:stop $TEST_APP --container $RUN_CONTAINER"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "docker container ls -q --filter name=^/$RUN_CONTAINER\$ | wc -l"
echo "output: $output"
echo "status: $status"
assert_success
assert_output "0"
}
@test "(run) docker-options and -e flags are not eval-injected" {
run deploy_app
echo "output: $output"