From 9dba48fc19d2040ba70efbd8031ac8716ad3331d Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Sun, 22 Nov 2020 00:00:05 -0500 Subject: [PATCH] feat: deprecate logs:failed without an argument or flag --- docs/appendices/0.22.0-migration-guide.md | 4 ++++ plugins/logs/subcommands.go | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/appendices/0.22.0-migration-guide.md b/docs/appendices/0.22.0-migration-guide.md index a4e4dc7f4..acc9a9d6a 100644 --- a/docs/appendices/0.22.0-migration-guide.md +++ b/docs/appendices/0.22.0-migration-guide.md @@ -1,5 +1,9 @@ # 0.22.0 Migration Guide +## Deprecations + +- Calling `logs:failed` without either a `` or the `--all` flag is deprecated. + ## Changes - Underscores are no longer valid characters in app names. Please rename applications before upgrading. diff --git a/plugins/logs/subcommands.go b/plugins/logs/subcommands.go index 836409b2a..8a41536e1 100644 --- a/plugins/logs/subcommands.go +++ b/plugins/logs/subcommands.go @@ -39,7 +39,7 @@ func CommandFailed(appName string, allApps bool) error { } if appName == "" { - common.LogWarn("Restore specified without app, assuming --all") + common.LogWarn("Deprecated: Restore specified without app, assuming --all") return common.RunCommandAgainstAllAppsSerially(GetFailedLogs, "logs:failed") }