github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: force set all plugin permissions on plugin:install/update

Browse Source 
Closes #4027
This commit is contained in:
Jose Diaz-Gonzalez
2020-07-17 14:37:59 -04:00
parent 59f815962d
commit 9ac7b00718
4 changed files with 98 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

66
tests/unit/plugin.bats
View File

@@ -180,3 +180,69 @@ teardown() {
echo "status: $status"
assert_failure
}
@test "(plugin) plugin:install permissions set properly" {
run /bin/bash -c "ls -lah /var/lib/dokku/core-plugins/available/git/commands"
echo "output: $output"
echo "status: $status"
assert_success
assert_output_contains "root" "0"
assert_output_contains "dokku" "3"
run /bin/bash -c "chown -R root:root /var/lib/dokku/core-plugins/available/git"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "ls -lah /var/lib/dokku/core-plugins/available/git/commands"
echo "output: $output"
echo "status: $status"
assert_success
assert_output_contains "root" "2"
assert_output_contains "dokku" "1"
run /bin/bash -c "dokku plugin:install"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "ls -lah /var/lib/dokku/core-plugins/available/git/commands"
echo "output: $output"
echo "status: $status"
assert_success
assert_output_contains "root" "0"
assert_output_contains "dokku" "3"
}
@test "(plugin) plugin:update permissions set properly" {
run /bin/bash -c "ls -lah /var/lib/dokku/core-plugins/available/git/commands"
echo "output: $output"
echo "status: $status"
assert_success
assert_output_contains "root" "0"
assert_output_contains "dokku" "3"
run /bin/bash -c "chown -R root:root /var/lib/dokku/core-plugins/available/git"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "ls -lah /var/lib/dokku/core-plugins/available/git/commands"
echo "output: $output"
echo "status: $status"
assert_success
assert_output_contains "root" "2"
assert_output_contains "dokku" "1"
run /bin/bash -c "dokku plugin:update"
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "ls -lah /var/lib/dokku/core-plugins/available/git/commands"
echo "output: $output"
echo "status: $status"
assert_success
assert_output_contains "root" "0"
assert_output_contains "dokku" "3"
}