fix: retire cron containers past their active deadline

Cron containers were never reaped once they exceeded their active deadline, so a hung cron task ran indefinitely instead of being retired after 24 hours as documented. `cron:run` now also accepts a `--ttl-seconds` argument, matching the one `dokku run` already takes.
This commit is contained in:
Jose Diaz-Gonzalez committed 2026-08-12 13:11:34 -04:00
1 parent 0bfd35dada
commit 96d726c43c
18 files changed
+1170 -906

No files matched your search

+7 -2
View File
@@ -5,6 +5,7 @@ import (
"errors"
"fmt"
"os"
"strconv"
"strings"
"github.com/dokku/dokku/plugins/common"
@@ -97,11 +98,15 @@ func CommandResume(appName string, cronID string) error {
}
// CommandRun executes a cron task on the fly
func CommandRun(appName string, cronID string, detached bool) error {
func CommandRun(appName string, cronID string, detached bool, ttlSeconds int64) error {
if err := common.VerifyAppName(appName); err != nil {
return err
}
if err := validateTTLSeconds(ttlSeconds); err != nil {
return err
}
tasks, err := FetchCronTasks(FetchCronTasksInput{AppName: appName})
if err != nil {
return err
@@ -139,7 +144,7 @@ func CommandRun(appName string, cronID string, detached bool) error {
os.Setenv("DOKKU_CONCURRENCY_POLICY", concurrencyPolicy)
os.Setenv("DOKKU_CRON_ID", cronID)
os.Setenv("DOKKU_RM_CONTAINER", "1")
os.Setenv("DOKKU_RUN_TTL_SECONDS", "86400")
os.Setenv("DOKKU_RUN_TTL_SECONDS", strconv.FormatInt(ttlSeconds, 10))
scheduler := common.GetAppScheduler(appName)
args := append([]string{scheduler, appName, "0", "--"}, fields...)
_, err = common.CallPlugnTrigger(common.PlugnTriggerInput{