feat: export environment variables during dockerfile builds for use with value-less --build-arg flags
Exposing all config values will allow users to skip setting environment variables twice - once as a docker option and once as an env var. Docker will automatically pull the value from the environment if none is set for the --build-arg flag. Users will still be required to specify each desired env var via --build-arg as otherwise docker builds will complain about unused build arguments. Re-implements #5978 (lost in a rebase) Closes #5903
This commit is contained in:
@@ -48,3 +48,21 @@ teardown() {
|
||||
assert_success
|
||||
assert_output_contains 'echo hi' 0
|
||||
}
|
||||
|
||||
@test "(builder-dockerfile) config export" {
|
||||
run /bin/bash -c "dokku config:set $TEST_APP GITHUB_TOKEN=custom-value"
|
||||
echo "output: $output"
|
||||
echo "status: $status"
|
||||
assert_success
|
||||
|
||||
run /bin/bash -c "dokku docker-options:add $TEST_APP build '--build-arg GITHUB_TOKEN'"
|
||||
echo "output: $output"
|
||||
echo "status: $status"
|
||||
assert_success
|
||||
|
||||
run deploy_app dockerfile
|
||||
echo "output: $output"
|
||||
echo "status: $status"
|
||||
assert_success
|
||||
assert_output_contains "TOKEN is: custom-value"
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user