github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: pass storage entry basename to chown-storage-dir

Browse Source 
storage:create --chown invoked chown-storage-dir with the full host path, but the helper validates a basename and prepends the storage root itself, so every call failed with `Directory can only contain the following set of characters`. Pass the entry name and reject the combination of --chown with a non-default host path, since the helper only manages the default storage location.
This commit is contained in:
Jose Diaz-Gonzalez
2026-05-29 20:49:12 -04:00
parent 59d880e3f9
commit 94c43f6dd8
3 changed files with 42 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/storage/commands_entries.go
View File

@@ -495,6 +495,13 @@ func CommandListEntries(scheduler string, format string) error {
// docker-local entry if it doesn't already exist. Idempotent: a
// pre-existing directory is left in place.
func ensureDockerLocalPath(entry *Entry) error {
if entry.Chown != "" && entry.Chown != "false" {
defaultHostPath := filepath.Join(GetStorageDirectory(), entry.Name)
if entry.HostPath != defaultHostPath {
return fmt.Errorf("--chown is only supported when the storage entry uses the default host path (%s); use --chown false and chown %s manually", defaultHostPath, entry.HostPath)
}
}
info, err := os.Stat(entry.HostPath)
if err != nil && !os.IsNotExist(err) {
return fmt.Errorf("unable to stat %s: %w", entry.HostPath, err)
@@ -519,7 +526,7 @@ func ensureDockerLocalPath(entry *Entry) error {
chownScript := filepath.Join(pluginPath, "storage", "bin", "chown-storage-dir")
result, err := common.CallExecCommand(common.ExecCommandInput{
Command: "sudo",
Args: []string{chownScript, entry.HostPath, chownID},
Args: []string{chownScript, entry.Name, chownID},
})
if err != nil {
return fmt.Errorf("unable to chown %s: %w", entry.HostPath, err)