github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: pass storage entry basename to chown-storage-dir

Browse Source 
storage:create --chown invoked chown-storage-dir with the full host path, but the helper validates a basename and prepends the storage root itself, so every call failed with `Directory can only contain the following set of characters`. Pass the entry name and reject the combination of --chown with a non-default host path, since the helper only manages the default storage location.
This commit is contained in:
Jose Diaz-Gonzalez
2026-05-29 20:49:12 -04:00
parent 59d880e3f9
commit 94c43f6dd8
3 changed files with 42 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/advanced-usage/persistent-storage.md
View File

@@ -95,6 +95,8 @@ By default, permissions are set for usage with Herokuish buildpacks. These permi
Users deploying via Dockerfile will want to specify `--chown false` and manually `chown` the created directory if the user and/or group id of the runnning process in the deployed container do not correspond to any of the above options.
The `--chown` flag - whether on `storage:create` or `storage:ensure-directory` - only manages the default `/var/lib/dokku/data/storage/<name>` location. If a custom `<path>` is passed to `storage:create`, the chown call is refused and the operator must chown the path themselves.
> [!WARNING]
> Failing to set the correct directory ownership may result in issues in persisting files written to the mounted storage directory.