diff --git a/dokku b/dokku index b11e051ec..4252f831f 100755 --- a/dokku +++ b/dokku @@ -10,7 +10,8 @@ export PLUGIN_PATH=${PLUGIN_PATH:="/var/lib/dokku/plugins"} export DOKKU_NOT_IMPLEMENTED_EXIT=10 export DOKKU_VALID_EXIT=0 -export DOKKU_EVENTS_LOGFILE=${DOKKU_EVENTS_LOGFILE:="/var/log/dokku.log"} +export DOKKU_LOGS_DIR=${DOKKU_LOGS_DIR:="/var/log/dokku"} +export DOKKU_EVENTS_LOGFILE=${DOKKU_EVENTS_LOGFILE:="$DOKKU_LOGS_DIR/events.log"} source "$PLUGIN_PATH/common/functions" diff --git a/plugins/20_events/install b/plugins/20_events/install index 1d352792b..494892bb5 100755 --- a/plugins/20_events/install +++ b/plugins/20_events/install @@ -7,6 +7,11 @@ DOKKU_LOGROTATE_FILE=/etc/logrotate.d/dokku flag_rsyslog_needs_restart=n +# This can be done unconditionally as mkdir -p +# exits gracefully if the path already exists +mkdir -m 775 -p "$DOKKU_LOGS_DIR" +chown syslog:dokku "$DOKKU_LOGS_DIR" + if [[ ! -f "$DOKKU_EVENTS_LOGFILE" ]]; then touch "$DOKKU_EVENTS_LOGFILE" # chown syslog:root might not work on SUSE @@ -23,7 +28,7 @@ fi if [[ ! -f "$DOKKU_LOGROTATE_FILE" ]]; then cat >"$DOKKU_LOGROTATE_FILE" <