From af8718cebe0b4c3143ba10a52ede03154311718c Mon Sep 17 00:00:00 2001
From: Jose Diaz-Gonzalez <email@josediazgonzalez.com>
Date: Sun, 20 Jan 2019 22:50:48 -0500
Subject: [PATCH] fix: ensure official golang plugins have correct help output

Previously, golang plugins would omit subcommands for 'dokku help --all', meaning they could not be introspected upon by outside tooling.
---
 plugins/config/src/commands/commands.go  | 15 ++++++++++++---
 plugins/network/src/commands/commands.go | 13 +++++++++++--
 plugins/repo/src/commands/commands.go    | 13 +++++++++++--
 3 files changed, 34 insertions(+), 7 deletions(-)

diff --git a/plugins/config/src/commands/commands.go b/plugins/config/src/commands/commands.go
index 04c0b121f..8d24c953c 100644
--- a/plugins/config/src/commands/commands.go
+++ b/plugins/config/src/commands/commands.go
@@ -7,6 +7,7 @@ import (
 	"strconv"
 	"strings"
 
+	"github.com/dokku/dokku/plugins/common"
 	"github.com/dokku/dokku/plugins/config"
 	columnize "github.com/ryanuber/columnize"
 )
@@ -43,10 +44,18 @@ func main() {
 		merged := args.Bool("merged", false, "--merged: display the app's environment merged with the global environment")
 		args.Parse(os.Args[2:])
 		config.CommandShow(args.Args(), *global, *shell, *export, *merged)
-	case "help":
-		fmt.Print("\n    config, Manages global and app-specific config vars\n")
 	case "config:help":
 		usage()
+	case "help":
+		command := common.NewShellCmd(fmt.Sprintf("ps -o command= %d", os.Getppid()))
+		command.ShowOutput = false
+		output, err := command.Output()
+
+		if err == nil && strings.Contains(string(output), "--all") {
+			fmt.Println(helpContent)
+		} else {
+			fmt.Print("\n    config, Manages global and app-specific config vars\n")
+		}
 	default:
 		dokkuNotImplementExitCode, err := strconv.Atoi(os.Getenv("DOKKU_NOT_IMPLEMENTED_EXIT"))
 		if err != nil {
@@ -58,11 +67,11 @@ func main() {
 }
 
 func usage() {
+	fmt.Println(helpHeader)
 	config := columnize.DefaultConfig()
 	config.Delim = ","
 	config.Prefix = "    "
 	config.Empty = ""
 	content := strings.Split(helpContent, "\n")[1:]
-	fmt.Println(helpHeader)
 	fmt.Println(columnize.Format(content, config))
 }
diff --git a/plugins/network/src/commands/commands.go b/plugins/network/src/commands/commands.go
index f67f470ff..e8d1fdcf8 100644
--- a/plugins/network/src/commands/commands.go
+++ b/plugins/network/src/commands/commands.go
@@ -7,6 +7,7 @@ import (
 	"strconv"
 	"strings"
 
+	"github.com/dokku/dokku/plugins/common"
 	columnize "github.com/ryanuber/columnize"
 )
 
@@ -34,7 +35,15 @@ func main() {
 	case "network", "network:help":
 		usage()
 	case "help":
-		fmt.Print("\n    network, Manages network settings for an app\n")
+		command := common.NewShellCmd(fmt.Sprintf("ps -o command= %d", os.Getppid()))
+		command.ShowOutput = false
+		output, err := command.Output()
+
+		if err == nil && strings.Contains(string(output), "--all") {
+			fmt.Println(helpContent)
+		} else {
+			fmt.Print("\n    network, Manages network settings for an app\n")
+		}
 	default:
 		dokkuNotImplementExitCode, err := strconv.Atoi(os.Getenv("DOKKU_NOT_IMPLEMENTED_EXIT"))
 		if err != nil {
@@ -46,11 +55,11 @@ func main() {
 }
 
 func usage() {
+	fmt.Println(helpHeader)
 	config := columnize.DefaultConfig()
 	config.Delim = ","
 	config.Prefix = "    "
 	config.Empty = ""
 	content := strings.Split(helpContent, "\n")[1:]
-	fmt.Println(helpHeader)
 	fmt.Println(columnize.Format(content, config))
 }
diff --git a/plugins/repo/src/commands/commands.go b/plugins/repo/src/commands/commands.go
index 63c5f1a76..8abaada25 100644
--- a/plugins/repo/src/commands/commands.go
+++ b/plugins/repo/src/commands/commands.go
@@ -7,6 +7,7 @@ import (
 	"strconv"
 	"strings"
 
+	"github.com/dokku/dokku/plugins/common"
 	columnize "github.com/ryanuber/columnize"
 )
 
@@ -32,7 +33,15 @@ func main() {
 	case "repo", "repo:help":
 		usage()
 	case "help":
-		fmt.Print("\n    repo, Runs commands that interact with the app's repo\n")
+		command := common.NewShellCmd(fmt.Sprintf("ps -o command= %d", os.Getppid()))
+		command.ShowOutput = false
+		output, err := command.Output()
+
+		if err == nil && strings.Contains(string(output), "--all") {
+			fmt.Println(helpContent)
+		} else {
+			fmt.Print("\n    repo, Runs commands that interact with the app's repo\n")
+		}
 	default:
 		dokkuNotImplementExitCode, err := strconv.Atoi(os.Getenv("DOKKU_NOT_IMPLEMENTED_EXIT"))
 		if err != nil {
@@ -44,11 +53,11 @@ func main() {
 }
 
 func usage() {
+	fmt.Println(helpHeader)
 	config := columnize.DefaultConfig()
 	config.Delim = ","
 	config.Prefix = "    "
 	config.Empty = ""
 	content := strings.Split(helpContent, "\n")[1:]
-	fmt.Println(helpHeader)
 	fmt.Println(columnize.Format(content, config))
 }