github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

feat: configure Traefik readiness healthchecks based on app.json config

Browse Source 
Closes #6834
This commit is contained in:
Jose Diaz-Gonzalez
2026-01-07 19:44:53 -05:00
parent b4c598ed17
commit 8cad6c3179
4 changed files with 134 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/apps/python/app-traefik.json Normal file
View File

@@ -0,0 +1,13 @@
{
"healthchecks": {
"web": [
{
"name": "web readiness check",
"path": "/",
"timeout": 5,
"type": "readiness",
"wait": 2
}
]
}
}

58
tests/unit/traefik.bats
View File

@@ -734,3 +734,61 @@ teardown() {
run /bin/bash -c "dokku traefik:set --global dns-provider-cf_api_email"
run /bin/bash -c "dokku traefik:set --global dns-provider-cf_api_key"
}
@test "(traefik) healthcheck labels from app.json" {
run /bin/bash -c "dokku proxy:set $TEST_APP traefik"
echo "output: $output"
echo "status: $status"
assert_success
run deploy_app python dokku@$DOKKU_DOMAIN:$TEST_APP setup_traefik_healthcheck
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "docker inspect $TEST_APP.web.1 --format '{{ index .Config.Labels \"traefik.http.services.$TEST_APP-web-http.loadbalancer.healthcheck.path\" }}'"
echo "output: $output"
echo "status: $status"
assert_success
assert_output "/"
run /bin/bash -c "docker inspect $TEST_APP.web.1 --format '{{ index .Config.Labels \"traefik.http.services.$TEST_APP-web-http.loadbalancer.healthcheck.timeout\" }}'"
echo "output: $output"
echo "status: $status"
assert_success
assert_output "5s"
run /bin/bash -c "docker inspect $TEST_APP.web.1 --format '{{ index .Config.Labels \"traefik.http.services.$TEST_APP-web-http.loadbalancer.healthcheck.interval\" }}'"
echo "output: $output"
echo "status: $status"
assert_success
assert_output "2s"
}
@test "(traefik) no healthcheck labels without readiness check" {
run /bin/bash -c "dokku proxy:set $TEST_APP traefik"
echo "output: $output"
echo "status: $status"
assert_success
run deploy_app python dokku@$DOKKU_DOMAIN:$TEST_APP
echo "output: $output"
echo "status: $status"
assert_success
run /bin/bash -c "docker inspect $TEST_APP.web.1 --format '{{ index .Config.Labels \"traefik.http.services.$TEST_APP-web-http.loadbalancer.healthcheck.path\" }}'"
echo "output: $output"
echo "status: $status"
assert_success
assert_output_not_exists
}
setup_traefik_healthcheck() {
local APP="$1"
local APP_REPO_DIR="$2"
[[ -z "$APP" ]] && local APP="$TEST_APP"
APP_REPO_DIR="$(realpath "$APP_REPO_DIR")"
mv "$APP_REPO_DIR/app-traefik.json" "$APP_REPO_DIR/app.json"
}