fix: storage plugin install setup and post-delete permissions

apps:destroy was failing in CI because the post-delete trigger called PropertyListWrite, which tried to mkdir /var/lib/dokku/config/storage/<app> as the dokku user but the parent directory had been created by the install trigger as root. The install trigger now calls PropertySetup("storage") so the per-plugin config root has the correct ownership, and post-delete / post-app-clone / post-app-rename short-circuit when the app has no attachments to begin with so they can't fail on a never-touched property tree. The entry registry and migration flag directories also moved out of config/storage (where they would have collided with the property-store path config/storage/<appName>) into a dedicated data/storage-registry tree.
This commit is contained in:
Jose Diaz-Gonzalez
2026-04-29 22:36:00 -04:00
parent b601a626f5
commit 89afd09087
4 changed files with 33 additions and 7 deletions

View File

@@ -14,6 +14,10 @@ import (
// TriggerInstall sets up the storage plugin on installation and runs
// the bulk legacy-mount migration once per upgrade.
func TriggerInstall() error {
if err := common.PropertySetup(PluginName); err != nil {
return fmt.Errorf("Unable to install the storage plugin: %s", err.Error())
}
storageDir := GetStorageDirectory()
if err := os.MkdirAll(storageDir, 0755); err != nil {
@@ -55,11 +59,17 @@ func TriggerInstall() error {
}
// TriggerPostDelete clears any attachment list for an app that's being
// destroyed. Entries are global and survive app deletion.
// destroyed. Entries are global and survive app deletion. Skipped when
// the app has no attachments to begin with so we don't trigger a
// pointless propertyTouch that could fail on installs with no
// property-list state for this plugin yet.
func TriggerPostDelete(appName string) error {
if appName == "" {
return nil
}
if !common.PropertyExists(PluginName, appName, AttachmentsProperty) {
return nil
}
return common.PropertyListWrite(PluginName, appName, AttachmentsProperty, []string{})
}
@@ -69,6 +79,9 @@ func TriggerPostAppCloneSetup(oldName string, newName string) error {
if oldName == "" || newName == "" {
return nil
}
if !common.PropertyExists(PluginName, oldName, AttachmentsProperty) {
return nil
}
attachments, err := LoadAttachments(oldName)
if err != nil {
return err
@@ -82,6 +95,9 @@ func TriggerPostAppRenameSetup(oldName string, newName string) error {
if oldName == "" || newName == "" {
return nil
}
if !common.PropertyExists(PluginName, oldName, AttachmentsProperty) {
return nil
}
attachments, err := LoadAttachments(oldName)
if err != nil {
return err