tests: run mvdan/shfmt on test runs

While I do not agree with _every_ style change, this will force Dokku to have consistent formatting across all shell scripts, which is arguably a Good Thing™.

The command used to reprocess everything is:

```shell
shfmt -l -bn -ci -i 2 -w .
```

plugins/git/commands

@@ -1,5 +1,6 @@
 #!/usr/bin/env bash
-set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x
+set -eo pipefail
+[[ $DOKKU_TRACE ]] && set -x
 source "$PLUGIN_AVAILABLE_PATH/git/functions"
 source "$PLUGIN_AVAILABLE_PATH/git/internal-functions"
 

plugins/git/deploy-source

@@ -1,5 +1,6 @@
 #!/usr/bin/env bash
-set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x
+set -eo pipefail
+[[ $DOKKU_TRACE ]] && set -x
 
 git_deploy_source() {
   declare desc="git deploy-source plugin trigger"
@@ -10,8 +11,8 @@ git_deploy_source() {
 
   # bail if another source is detected
   if [[ -n "$STDIN" ]]; then
-  	echo "$STDIN"
-  	return
+    echo "$STDIN"
+    return
   fi
 
   if [[ -d "$DOKKU_ROOT/$APP/refs" ]]; then

plugins/git/functions

@@ -3,7 +3,8 @@ source "$PLUGIN_CORE_AVAILABLE_PATH/common/functions"
 source "$PLUGIN_CORE_AVAILABLE_PATH/common/property-functions"
 source "$PLUGIN_AVAILABLE_PATH/apps/functions"
 source "$PLUGIN_AVAILABLE_PATH/config/functions"
-set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x
+set -eo pipefail
+[[ $DOKKU_TRACE ]] && set -x
 
 use_git_worktree() {
   declare desc="detects whether to use git worktree"
@@ -37,16 +38,16 @@ git_build_app_repo() {
   chmod 755 "$GIT_BUILD_APP_REPO_TMP_WORK_DIR"
   unset GIT_DIR GIT_WORK_TREE
 
-  ! apps_exists "$APP" > /dev/null 2>&1 && apps_maybe_create "$APP"
+  ! apps_exists "$APP" >/dev/null 2>&1 && apps_maybe_create "$APP"
 
   if use_git_worktree; then
     # git worktree - this method uses git worktree which was introduced in git 2.5
-    pushd "$DOKKU_ROOT/$APP" > /dev/null
+    pushd "$DOKKU_ROOT/$APP" >/dev/null
     # unset the git quarantine path to allow us to use 2.13.0+
     # See this issue for more information: https://github.com/dokku/dokku/issues/2796
     suppress_output env -u GIT_QUARANTINE_PATH git worktree add "$GIT_BUILD_APP_REPO_TMP_WORK_DIR" "$REV"
-    popd > /dev/null 2>&1 || pushd "/tmp" > /dev/null
-    pushd "$GIT_BUILD_APP_REPO_TMP_WORK_DIR" > /dev/null
+    popd >/dev/null 2>&1 || pushd "/tmp" >/dev/null
+    pushd "$GIT_BUILD_APP_REPO_TMP_WORK_DIR" >/dev/null
   else
     # git clone - this method creates a new git repository and adds the primary
     #             repo as a remote, then does a fetch depth=1 to avoid cloning
@@ -54,24 +55,24 @@ git_build_app_repo() {
     #             Not working for git >= 2.11.0 due to changes introduced
     #             in this merge:
     #             https://github.com/git/git/commit/25ab004c53cdcfea485e5bf437aeaa74df47196d
-    pushd "$GIT_BUILD_APP_REPO_TMP_WORK_DIR" > /dev/null
-    GIT_DIR="$DOKKU_ROOT/$APP" git tag -d "$TMP_TAG" &> /dev/null || true
-    GIT_DIR="$DOKKU_ROOT/$APP" git tag "$TMP_TAG" "$REV" &> /dev/null
-    git init &> /dev/null
+    pushd "$GIT_BUILD_APP_REPO_TMP_WORK_DIR" >/dev/null
+    GIT_DIR="$DOKKU_ROOT/$APP" git tag -d "$TMP_TAG" &>/dev/null || true
+    GIT_DIR="$DOKKU_ROOT/$APP" git tag "$TMP_TAG" "$REV" &>/dev/null
+    git init &>/dev/null
     git config advice.detachedHead false
-    git remote add origin "$DOKKU_ROOT/$APP" &> /dev/null
-    git fetch --depth=1 origin "refs/tags/$TMP_TAG" &> /dev/null
-    git reset --hard FETCH_HEAD &> /dev/null
-    GIT_DIR="$DOKKU_ROOT/$APP" git tag -d "$TMP_TAG" &> /dev/null || true
+    git remote add origin "$DOKKU_ROOT/$APP" &>/dev/null
+    git fetch --depth=1 origin "refs/tags/$TMP_TAG" &>/dev/null
+    git reset --hard FETCH_HEAD &>/dev/null
+    GIT_DIR="$DOKKU_ROOT/$APP" git tag -d "$TMP_TAG" &>/dev/null || true
   fi
 
   suppress_output env -u GIT_QUARANTINE_PATH git submodule update --init --recursive
-  find . -name .git -prune -exec rm -rf {} \; > /dev/null
+  find . -name .git -prune -exec rm -rf {} \; >/dev/null
 
   if use_git_worktree; then
-    pushd "$DOKKU_ROOT/$APP" > /dev/null
+    pushd "$DOKKU_ROOT/$APP" >/dev/null
     git worktree prune
-    popd > /dev/null
+    popd >/dev/null
   fi
 
   local DOKKU_APP_DISABLE_ANSI_PREFIX_REMOVAL DOKKU_GLOBAL_DISABLE_ANSI_PREFIX_REMOVAL DOKKU_DISABLE_ANSI_PREFIX_REMOVAL
@@ -91,7 +92,10 @@ git_trigger_build() {
   declare APP="$1" TMP_WORK_DIR="$2" REV="$3"
 
   plugn trigger post-extract "$APP" "$TMP_WORK_DIR" "$REV"
-  if [[ -f Dockerfile ]] && [[ "$([[ -f .env ]] && grep -q BUILDPACK_URL .env; echo $?)" != "0" ]] && [[ ! -f ".buildpacks" ]] && [[ -z $(config_get "$APP" BUILDPACK_URL || true) ]]; then
+  if [[ -f Dockerfile ]] && [[ "$(
+    [[ -f .env ]] && grep -q BUILDPACK_URL .env
+    echo $?
+  )" != "0" ]] && [[ ! -f ".buildpacks" ]] && [[ -z $(config_get "$APP" BUILDPACK_URL || true) ]]; then
     plugn trigger pre-receive-app "$APP" "dockerfile" "$TMP_WORK_DIR" "$REV"
     dokku_receive "$APP" "dockerfile" "$TMP_WORK_DIR"
   else
@@ -119,12 +123,12 @@ git_deploy_branch() {
 git_hook_cmd() {
   declare desc="kick off receive-app trigger from git prereceive hook"
   local cmd="git-hook"
-  local APP="$2"  
+  local APP="$2"
   local DOKKU_DEPLOY_BRANCH
   is_valid_app_name "$APP"
 
   DOKKU_DEPLOY_BRANCH="$(git_deploy_branch "$APP")"
-  if ! git check-ref-format --branch "$DOKKU_DEPLOY_BRANCH" > /dev/null 2>&1; then
+  if ! git check-ref-format --branch "$DOKKU_DEPLOY_BRANCH" >/dev/null 2>&1; then
     echo $'\e[1G\e[K'"-----> WARNING: Invalid branch name '$DOKKU_DEPLOY_BRANCH' specified via DOKKU_DEPLOY_BRANCH."
     echo $'\e[1G\e[K'"-----> For more details, please see the man page for 'git-check-ref-format.'"
     return
@@ -134,7 +138,7 @@ git_hook_cmd() {
   while read -r oldrev newrev refname; do
     # Only run this script for the master branch. You can remove this
     # if block if you wish to run it for others as well.
-    if [[ $refname = "refs/heads/${DOKKU_DEPLOY_BRANCH}" ]]; then
+    if [[ $refname == "refs/heads/${DOKKU_DEPLOY_BRANCH}" ]]; then
       # broken out into plugin so we might support other methods to receive an app
       # shellcheck disable=SC2086
       git_receive_app "$APP" "$newrev"
@@ -144,7 +148,7 @@ git_hook_cmd() {
         plugn trigger receive-branch $APP $newrev $refname
       else
         echo $'\e[1G\e[K'"-----> WARNING: deploy did not complete, you must push to master."
-        echo $'\e[1G\e[K'"-----> for example, try 'git push <dokku> ${refname/refs\/heads\/}:master'"
+        echo $'\e[1G\e[K'"-----> for example, try 'git push <dokku> ${refname/refs\/heads\//}:master'"
       fi
     fi
   done
@@ -156,17 +160,17 @@ git_build() {
   local DOKKU_DEPLOY_BRANCH ENV_VAR_NAME REF
   if [[ $# -ge 2 ]]; then
     ENV_VAR_NAME="$(fn-plugin-property-get "git" "$APP" "rev-env-var")"
-    if [[ -z "$ENV_VAR_NAME" ]] && ! fn-plugin-property-exists  "git" "$APP" "rev-env-var"; then
+    if [[ -z "$ENV_VAR_NAME" ]] && ! fn-plugin-property-exists "git" "$APP" "rev-env-var"; then
       ENV_VAR_NAME="GIT_REV"
     fi
 
     if [[ -n "$ENV_VAR_NAME" ]]; then
-      config_set --no-restart "$APP" "${ENV_VAR_NAME}=${REV}" > /dev/null
+      config_set --no-restart "$APP" "${ENV_VAR_NAME}=${REV}" >/dev/null
     fi
     local REF="$REV"
   else
     DOKKU_DEPLOY_BRANCH="$(git_deploy_branch "$APP")"
-    REF=$(< "$DOKKU_ROOT/$APP/refs/heads/$DOKKU_DEPLOY_BRANCH")
+    REF=$(<"$DOKKU_ROOT/$APP/refs/heads/$DOKKU_DEPLOY_BRANCH")
   fi
 
   # shellcheck disable=SC2086
@@ -194,7 +198,7 @@ git_upload_pack_cmd() {
   declare APP="$2"
   APP="$(echo "$APP" | perl -pe 's/(?<!\\)'\''//g' | sed 's/\\'\''/'\''/g' | sed 's/^\///g')"
   is_valid_app_name "$APP"
-  ! apps_exists "$APP" > /dev/null 2>&1 && apps_maybe_create "$APP"
+  ! apps_exists "$APP" >/dev/null 2>&1 && apps_maybe_create "$APP"
 
   plugn trigger git-pre-pull "$APP"
   cat | git-upload-pack "$DOKKU_ROOT/$APP"
@@ -209,7 +213,7 @@ git_glob_cmd() {
   is_valid_app_name "$APP"
 
   if [[ $1 == "git-receive-pack" && ! -d "$APP_PATH/refs" ]]; then
-    ! apps_exists "$APP" > /dev/null 2>&1 && apps_maybe_create "$APP"
+    ! apps_exists "$APP" >/dev/null 2>&1 && apps_maybe_create "$APP"
 
     fn-git-create-hook "$APP"
   fi
@@ -229,10 +233,10 @@ fn-git-create-hook() {
   verify_app_name "$APP"
 
   if [[ ! -d "$APP_PATH/refs" ]]; then
-    git init --bare "$APP_PATH" > /dev/null
+    git init --bare "$APP_PATH" >/dev/null
   fi
 
-  cat > "$PRERECEIVE_HOOK" <<EOF
+  cat >"$PRERECEIVE_HOOK" <<EOF
 #!/usr/bin/env bash
 set -e; set -o pipefail;
 

plugins/git/install

@@ -1,5 +1,6 @@
 #!/usr/bin/env bash
-set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x
+set -eo pipefail
+[[ $DOKKU_TRACE ]] && set -x
 source "$PLUGIN_CORE_AVAILABLE_PATH/common/functions"
 source "$PLUGIN_CORE_AVAILABLE_PATH/common/property-functions"
 source "$PLUGIN_AVAILABLE_PATH/config/functions"

plugins/git/internal-functions

@@ -1,7 +1,8 @@
 #!/usr/bin/env bash
 source "$PLUGIN_CORE_AVAILABLE_PATH/common/functions"
 source "$PLUGIN_CORE_AVAILABLE_PATH/common/property-functions"
-set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x
+set -eo pipefail
+[[ $DOKKU_TRACE ]] && set -x
 
 cmd-git-report() {
   declare desc="displays a git report for one or more apps"
@@ -46,7 +47,8 @@ cmd-git-report-single() {
       dokku_log_verbose "$(printf "%-30s %-25s" "${key^}" "${flag#*: }")"
     done
   else
-    local match=false; local value_exists=false
+    local match=false
+    local value_exists=false
     for flag in "${flag_map[@]}"; do
       valid_flags="${valid_flags} $(echo "$flag" | cut -d':' -f1)"
       if [[ "$flag" == "${INFO_FLAG}:"* ]]; then
@@ -66,7 +68,7 @@ cmd-git-report-single() {
 
 git_help_content_func() {
   declare desc="return git plugin help content"
-  cat<<help_content
+  cat <<help_content
     git:initialize <app>, Initialize a git repository for an app
     git:report [<app>] [<flag>], Displays a git report for one or more apps
     git:set <app> <property> (<value>), Set or clear a git property for an app
@@ -74,7 +76,7 @@ help_content
 }
 
 cmd-git-help() {
-  if [[ $1 = "git:help" ]] ; then
+  if [[ $1 == "git:help" ]]; then
     echo -e 'Usage: dokku git[:COMMAND]'
     echo ''
     echo 'Manages the git integration for an app.'
@@ -85,7 +87,7 @@ cmd-git-help() {
   elif [[ $(ps -o command= $PPID) == *"--all"* ]]; then
     git_help_content_func
   else
-    cat<<help_desc
+    cat <<help_desc
     git, Manages the git integration for an app
 help_desc
   fi

plugins/git/post-delete

@@ -1,5 +1,6 @@
 #!/usr/bin/env bash
-set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x
+set -eo pipefail
+[[ $DOKKU_TRACE ]] && set -x
 source "$PLUGIN_CORE_AVAILABLE_PATH/common/property-functions"
 
 trigger-git-post-delete() {

plugins/git/receive-app

@@ -1,5 +1,6 @@
 #!/usr/bin/env bash
-set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x
+set -eo pipefail
+[[ $DOKKU_TRACE ]] && set -x
 source "$PLUGIN_AVAILABLE_PATH/git/functions"
 
 git_receive_app "$@"

plugins/git/report

@@ -1,5 +1,6 @@
 #!/usr/bin/env bash
 source "$PLUGIN_AVAILABLE_PATH/git/internal-functions"
-set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x
+set -eo pipefail
+[[ $DOKKU_TRACE ]] && set -x
 
 cmd-git-report-single "$@"

plugins/git/subcommands/default

@@ -1,5 +1,6 @@
 #!/usr/bin/env bash
-set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x
+set -eo pipefail
+[[ $DOKKU_TRACE ]] && set -x
 source "$PLUGIN_AVAILABLE_PATH/git/internal-functions"
 
 cmd-git-help "git:help"

plugins/git/subcommands/initialize

@@ -1,11 +1,13 @@
 #!/usr/bin/env bash
 source "$PLUGIN_CORE_AVAILABLE_PATH/common/functions"
 source "$PLUGIN_AVAILABLE_PATH/git/functions"
-set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x
+set -eo pipefail
+[[ $DOKKU_TRACE ]] && set -x
 
 git-initialize-cmd() {
   declare desc="initialize a git repository for an app"
-  local cmd="git:initialize" argv=("$@"); [[ ${argv[0]} == "$cmd" ]] && shift 1
+  local cmd="git:initialize" argv=("$@")
+  [[ ${argv[0]} == "$cmd" ]] && shift 1
   declare APP="$1"
   is_valid_app_name "$APP"
 

plugins/git/subcommands/report

@@ -1,5 +1,6 @@
 #!/usr/bin/env bash
 source "$PLUGIN_AVAILABLE_PATH/git/internal-functions"
-set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x
+set -eo pipefail
+[[ $DOKKU_TRACE ]] && set -x
 
 cmd-git-report "$@"

plugins/git/subcommands/set

@@ -1,7 +1,8 @@
 #!/usr/bin/env bash
 source "$PLUGIN_CORE_AVAILABLE_PATH/common/functions"
 source "$PLUGIN_CORE_AVAILABLE_PATH/common/property-functions"
-set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x
+set -eo pipefail
+[[ $DOKKU_TRACE ]] && set -x
 
 fn-in-array() {
   declare desc="return true if value ($1) is in list (all other arguments)"
@@ -15,7 +16,8 @@ fn-in-array() {
 
 git-set-cmd() {
   declare desc="set or clear a git property for an app"
-  local cmd="git:set" argv=("$@"); [[ ${argv[0]} == "$cmd" ]] && shift 1
+  local cmd="git:set" argv=("$@")
+  [[ ${argv[0]} == "$cmd" ]] && shift 1
   declare APP="$1" KEY="$2" VALUE="$3"
   local VALID_KEYS=("deploy-branch" "rev-env-var")
   [[ -z "$APP" ]] && dokku_log_fail "Please specify an app to run the command on"