github/dokku
0
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: reject per-app sets for global-only proxy properties

Browse Source 
`caddy:set`, `haproxy:set`, and `traefik:set` previously accepted per-app writes for properties that only have a single host-wide reader, so `:set myapp image foo:bar` printed a success message while `:report myapp` kept showing the global default. The per-app form is now rejected with `The key '<key>' can only be set globally`, matching the existing rejection used for haproxy `refresh-conf` and traefik `challenge-mode`. Caddy `tls-internal` remains the only legitimate per-app property in this family.
This commit is contained in:
Jose Diaz-Gonzalez
2026-05-10 22:42:57 -04:00
parent a553f04966
commit 822b7dddcd
6 changed files with 62 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/haproxy-vhosts/subcommands/set
View File

@@ -11,7 +11,7 @@ cmd-haproxy-set() {
declare APP="$1" KEY="$2" VALUE="$3"
local VALID_KEYS=("image" "log-level" "letsencrypt-email" "letsencrypt-server" "refresh-conf")
local GLOBAL_KEYS=("image" "log-level" "letsencrypt-email" "letsencrypt-server" "refresh-conf")
local GLOBAL_ONLY_KEYS=("refresh-conf")
local GLOBAL_ONLY_KEYS=("image" "log-level" "letsencrypt-email" "letsencrypt-server" "refresh-conf")
[[ -z "$KEY" ]] && dokku_log_fail "No key specified"